From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1bG95t-0001Es-Gx
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 14:11:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1bG95n-0002Od-Cl
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 14:11:12 -0400
Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:33989)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1bG95n-0002OP-88
	for qemu-devel@nongnu.org; Thu, 23 Jun 2016 14:11:07 -0400
Received: by mail-oi0-x242.google.com with SMTP id s17so13679783oih.1
	for <qemu-devel@nongnu.org>; Thu, 23 Jun 2016 11:11:07 -0700 (PDT)
MIME-Version: 1.0
Sender: alistair23@gmail.com
In-Reply-To: <CAFEAcA84nKXQz-tMd7uKP0F-YnS5x+nawNcnTOzwDo34SwySaA@mail.gmail.com>
References: <cover.1466626975.git.alistair.francis@xilinx.com>
	<6ae9a75f0189ac76f8fc0b74ec85eb45b443d9af.1466626975.git.alistair.francis@xilinx.com>
	<CAFEAcA80BFgn-DvgwbXWg4nt3KqarKyLGyNZ2WOxNU6AbOcQJg@mail.gmail.com>
	<CAKmqyKMyZzaw_9F8WBdQsmS8RNz4spUw+UV_R93PXB313ctwQA@mail.gmail.com>
	<CAFEAcA84nKXQz-tMd7uKP0F-YnS5x+nawNcnTOzwDo34SwySaA@mail.gmail.com>
From: Alistair Francis <alistair.francis@xilinx.com>
Date: Thu, 23 Jun 2016 11:10:37 -0700
Message-ID: <CAKmqyKMquNXQyAjaiDcE5jcsDkSxAHXf+77s06dfX1SRkZYUxw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v7 06/12] register: Add block initialise
 helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>, Edgar Iglesias <edgar.iglesias@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, =?UTF-8?Q?Andreas_F=C3=A4rber?= <afaerber@suse.de>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>

On Thu, Jun 23, 2016 at 11:02 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 23 June 2016 at 18:29, Alistair Francis <alistair.francis@xilinx.com> wrote:
>> On Thu, Jun 23, 2016 at 5:55 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> It's not clear to me which of these are input arguments to the
>>> function, and which are things that the function initializes
>>> (I think 'ri' is purely output?)
>>
>> The function expects everything to already be initialised, it just
>> wires them up.
>>
>> ri should already be allocated, this function just sets up some pointers to it.
>>
>> I added a comment in the description saying that ri and data must
>> already be allocated. Is that enough?
>
> Does the caller have to initialize the array that ri points to
> before it calls this?

All the caller has to do is ensure that the array exists and is large
enough for the number of registers.

Thanks,

Alistair

>
> thanks
> -- PMM
>