qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Frank Chang <frank.chang@sifive.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 0/3] Fix RVV calling incorrect RFV/RVD check functions bug
Date: Thu, 6 Jan 2022 08:30:47 +1000	[thread overview]
Message-ID: <CAKmqyKMrEw=XC_hM7L8qXC7og6QGaJDDo+GTo508HuHvk5VaxA@mail.gmail.com> (raw)
In-Reply-To: <20220105022247.21131-1-frank.chang@sifive.com>

On Wed, Jan 5, 2022 at 12:23 PM <frank.chang@sifive.com> wrote:
>
> From: Frank Chang <frank.chang@sifive.com>
>
> For vector widening and narrowing floating-point instructions, we should
> use require_scale_rvf() instead of require_rvf() to check whether the
> correspond RVF/RVD is enabled if either source or destination
> floating-point operand is double-width of SEW. Otherwise, illegal
> instruction exception should be raised.
>
> e.g. For SEW=16, if the source/destination floating-point operand is
> double-width of SEW, RVF needs to be enabled. Otherwise, an illegal
> instruction exception will be raised. Similarly, for SEW=32, RVD
> needs to be enabled.
>
> Changelog:
>
> v2:
>   * Fix patch title typos.
>   * Add missing Signed-off-by.
>
> Frank Chang (3):
>   target/riscv: rvv-1.0: Call the correct RVF/RVD check function for
>     widening fp insns
>   target/riscv: rvv-1.0: Call the correct RVF/RVD check function for
>     widening fp/int type-convert insns
>   target/riscv: rvv-1.0: Call the correct RVF/RVD check function for
>     narrowing fp/int type-convert insns

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  target/riscv/insn_trans/trans_rvv.c.inc | 78 ++++++++++++++++++-------
>  1 file changed, 57 insertions(+), 21 deletions(-)
>
> --
> 2.31.1
>
>


      parent reply	other threads:[~2022-01-05 22:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  2:22 [PATCH v2 0/3] Fix RVV calling incorrect RFV/RVD check functions bug frank.chang
2022-01-05  2:22 ` [PATCH v2 1/3] target/riscv: rvv-1.0: Call the correct RVF/RVD check function for widening fp insns frank.chang
2022-01-05 21:44   ` Alistair Francis
2022-01-05  2:22 ` [PATCH v2 2/3] target/riscv: rvv-1.0: Call the correct RVF/RVD check function for widening fp/int type-convert insns frank.chang
2022-01-05 21:46   ` Alistair Francis
2022-01-05  2:22 ` [PATCH v2 3/3] target/riscv: rvv-1.0: Call the correct RVF/RVD check function for narrowing " frank.chang
2022-01-05 21:47   ` Alistair Francis
2022-01-05 22:30 ` Alistair Francis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKMrEw=XC_hM7L8qXC7og6QGaJDDo+GTo508HuHvk5VaxA@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=frank.chang@sifive.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).