* [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro
@ 2017-08-30 18:02 Alistair Francis
2017-08-30 22:12 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Alistair Francis @ 2017-08-30 18:02 UTC (permalink / raw)
To: qemu-devel, jcmvbkbc; +Cc: alistair.francis, alistair23
Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes
let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead.
Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---
target/xtensa/op_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c
index 519fbeddd6..3d990c0caa 100644
--- a/target/xtensa/op_helper.c
+++ b/target/xtensa/op_helper.c
@@ -1025,11 +1025,11 @@ void HELPER(ule_s)(CPUXtensaState *env, uint32_t br, float32 a, float32 b)
uint32_t HELPER(rer)(CPUXtensaState *env, uint32_t addr)
{
return address_space_ldl(env->address_space_er, addr,
- (MemTxAttrs){0}, NULL);
+ MEMTXATTRS_UNSPECIFIED, NULL);
}
void HELPER(wer)(CPUXtensaState *env, uint32_t data, uint32_t addr)
{
address_space_stl(env->address_space_er, addr, data,
- (MemTxAttrs){0}, NULL);
+ MEMTXATTRS_UNSPECIFIED, NULL);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro
2017-08-30 18:02 [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro Alistair Francis
@ 2017-08-30 22:12 ` Peter Maydell
2017-08-31 17:21 ` Alistair Francis
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2017-08-30 22:12 UTC (permalink / raw)
To: Alistair Francis; +Cc: QEMU Developers, Max Filippov, Alistair Francis
On 30 August 2017 at 19:02, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes
> let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
>
> target/xtensa/op_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c
> index 519fbeddd6..3d990c0caa 100644
> --- a/target/xtensa/op_helper.c
> +++ b/target/xtensa/op_helper.c
> @@ -1025,11 +1025,11 @@ void HELPER(ule_s)(CPUXtensaState *env, uint32_t br, float32 a, float32 b)
> uint32_t HELPER(rer)(CPUXtensaState *env, uint32_t addr)
> {
> return address_space_ldl(env->address_space_er, addr,
> - (MemTxAttrs){0}, NULL);
> + MEMTXATTRS_UNSPECIFIED, NULL);
> }
>
> void HELPER(wer)(CPUXtensaState *env, uint32_t data, uint32_t addr)
> {
> address_space_stl(env->address_space_er, addr, data,
> - (MemTxAttrs){0}, NULL);
> + MEMTXATTRS_UNSPECIFIED, NULL);
> }
Might be worth noting in the commit that this is technically
a change of behaviour, because MEMTXATTRS_UNSPECIFIED
sets the 'unspecified' field to 1 whereas {0} doesn't.
I don't think anything actually checks that field, though.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro
2017-08-30 22:12 ` Peter Maydell
@ 2017-08-31 17:21 ` Alistair Francis
0 siblings, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2017-08-31 17:21 UTC (permalink / raw)
To: Peter Maydell; +Cc: Alistair Francis, QEMU Developers, Max Filippov
On Wed, Aug 30, 2017 at 3:12 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 August 2017 at 19:02, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
>> Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes
>> let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> ---
>>
>> target/xtensa/op_helper.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c
>> index 519fbeddd6..3d990c0caa 100644
>> --- a/target/xtensa/op_helper.c
>> +++ b/target/xtensa/op_helper.c
>> @@ -1025,11 +1025,11 @@ void HELPER(ule_s)(CPUXtensaState *env, uint32_t br, float32 a, float32 b)
>> uint32_t HELPER(rer)(CPUXtensaState *env, uint32_t addr)
>> {
>> return address_space_ldl(env->address_space_er, addr,
>> - (MemTxAttrs){0}, NULL);
>> + MEMTXATTRS_UNSPECIFIED, NULL);
>> }
>>
>> void HELPER(wer)(CPUXtensaState *env, uint32_t data, uint32_t addr)
>> {
>> address_space_stl(env->address_space_er, addr, data,
>> - (MemTxAttrs){0}, NULL);
>> + MEMTXATTRS_UNSPECIFIED, NULL);
>> }
>
> Might be worth noting in the commit that this is technically
> a change of behaviour, because MEMTXATTRS_UNSPECIFIED
> sets the 'unspecified' field to 1 whereas {0} doesn't.
> I don't think anything actually checks that field, though.
Good point, I have added something to the commit message to indicate
that. It'll be included in v2.
Thanks,
Alistair
>
> thanks
> -- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-31 17:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-30 18:02 [Qemu-devel] [PATCH v1 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro Alistair Francis
2017-08-30 22:12 ` Peter Maydell
2017-08-31 17:21 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).