From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PATCH v3 07/19] target/riscv: Convert misa_mxl_max using GLib macros
Date: Mon, 17 Feb 2025 15:13:24 +1000 [thread overview]
Message-ID: <CAKmqyKN33mRHYY44Cw7341x48MM8=TCPsR8EvWNFTsyrgqSQBw@mail.gmail.com> (raw)
In-Reply-To: <20250212213249.45574-8-philmd@linaro.org>
On Thu, Feb 13, 2025 at 7:34 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> Use GLib conversion macros to pass misa_mxl_max as
> riscv_cpu_class_init() class data.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/cpu.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index f3ad7f88f0e..9fe1b23a297 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -2955,7 +2955,7 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
> {
> RISCVCPUClass *mcc = RISCV_CPU_CLASS(c);
>
> - mcc->misa_mxl_max = (RISCVMXL)(uintptr_t)data;
> + mcc->misa_mxl_max = (RISCVMXL)GPOINTER_TO_UINT(data);
> riscv_cpu_validate_misa_mxl(mcc);
> }
>
> @@ -3057,7 +3057,7 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> .parent = TYPE_RISCV_CPU, \
> .instance_init = (initfn), \
> .class_init = riscv_cpu_class_init, \
> - .class_data = (void *)(misa_mxl_max) \
> + .class_data = GUINT_TO_POINTER(misa_mxl_max) \
> }
>
> #define DEFINE_DYNAMIC_CPU(type_name, misa_mxl_max, initfn) \
> @@ -3066,7 +3066,7 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> .parent = TYPE_RISCV_DYNAMIC_CPU, \
> .instance_init = (initfn), \
> .class_init = riscv_cpu_class_init, \
> - .class_data = (void *)(misa_mxl_max) \
> + .class_data = GUINT_TO_POINTER(misa_mxl_max) \
> }
>
> #define DEFINE_VENDOR_CPU(type_name, misa_mxl_max, initfn) \
> @@ -3075,7 +3075,7 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> .parent = TYPE_RISCV_VENDOR_CPU, \
> .instance_init = (initfn), \
> .class_init = riscv_cpu_class_init, \
> - .class_data = (void *)(misa_mxl_max) \
> + .class_data = GUINT_TO_POINTER(misa_mxl_max) \
> }
>
> #define DEFINE_BARE_CPU(type_name, misa_mxl_max, initfn) \
> @@ -3084,7 +3084,7 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> .parent = TYPE_RISCV_BARE_CPU, \
> .instance_init = (initfn), \
> .class_init = riscv_cpu_class_init, \
> - .class_data = (void *)(misa_mxl_max) \
> + .class_data = GUINT_TO_POINTER(misa_mxl_max) \
> }
>
> #define DEFINE_PROFILE_CPU(type_name, misa_mxl_max, initfn) \
> @@ -3093,7 +3093,7 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, char *nodename)
> .parent = TYPE_RISCV_BARE_CPU, \
> .instance_init = (initfn), \
> .class_init = riscv_cpu_class_init, \
> - .class_data = (void *)(misa_mxl_max) \
> + .class_data = GUINT_TO_POINTER(misa_mxl_max) \
> }
>
> static const TypeInfo riscv_cpu_type_infos[] = {
> --
> 2.47.1
>
>
next prev parent reply other threads:[~2025-02-17 5:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 21:32 [PATCH v3 00/19] qom: Constify class_data Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 01/19] hw: Declare various const data as 'const' Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 02/19] hw: Make class data 'const' Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 03/19] target/i386: Constify X86CPUModel uses Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 04/19] target/sparc: Constify SPARCCPUClass::cpu_def Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 05/19] target/xtensa: Finalize config in xtensa_register_core() Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 06/19] target/riscv: Declare RISCVCPUClass::misa_mxl_max as RISCVMXL Philippe Mathieu-Daudé
2025-02-17 5:08 ` Alistair Francis
2025-02-12 21:32 ` [PATCH v3 07/19] target/riscv: Convert misa_mxl_max using GLib macros Philippe Mathieu-Daudé
2025-02-17 5:13 ` Alistair Francis [this message]
2025-02-12 21:32 ` [PATCH v3 08/19] qom: Have class_base_init() take a const data argument Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 09/19] qom: Have class_init() " Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 10/19] qom: Constify TypeInfo::class_data Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 11/19] qom: Constify InterfaceInfo[] interfaces Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 12/19] hw/virtio/virtio-pci: Always allocate QOM type base_name Philippe Mathieu-Daudé
2025-02-12 22:06 ` Richard Henderson
2025-02-12 21:32 ` [PATCH v3 13/19] hw/virtio/virtio-pci: Assert before registering QOM types Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 14/19] hw/virtio/virtio-pci: Do not access base_type_info.name directly Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 15/19] hw/virtio/virtio-pci: Constify base_type_info Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 16/19] hw/virtio/virtio-pci: Constify generic_type_info Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 17/19] hw/virtio/virtio-pci: Reduce generic_type_info scope Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 18/19] hw: Constify various TypeInfo and associated structures Philippe Mathieu-Daudé
2025-02-12 22:10 ` Richard Henderson
2025-02-12 21:32 ` [PATCH v3 19/19] qom: Require TypeInfo::class_data points to const data Philippe Mathieu-Daudé
2025-02-12 22:11 ` Richard Henderson
2025-02-18 16:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKN33mRHYY44Cw7341x48MM8=TCPsR8EvWNFTsyrgqSQBw@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).