From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEB8C433E6 for ; Fri, 19 Mar 2021 13:22:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1A1E64ED7 for ; Fri, 19 Mar 2021 13:22:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1A1E64ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNF56-00076P-UY for qemu-devel@archiver.kernel.org; Fri, 19 Mar 2021 09:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59906) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNF3n-0005ku-Fg; Fri, 19 Mar 2021 09:21:03 -0400 Received: from mail-il1-x12a.google.com ([2607:f8b0:4864:20::12a]:43711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNF3k-0000pq-UF; Fri, 19 Mar 2021 09:21:03 -0400 Received: by mail-il1-x12a.google.com with SMTP id d2so7977898ilm.10; Fri, 19 Mar 2021 06:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y+wXREcz+G27txgq0Zyw9ZKW7U/CnCbXn9a5uKaTow4=; b=SwdIIYAZ1UH9ahWmONx+VeVqe/HZ6iQG4O8SKm0GdymqmVrFKVlUXYeqe75i59X57Y 69srAY9NgFIY8AJQbQRDeJs/oGcFwL6DiHinFGBIKl+/7Wwyhq6KwWMSYcDdZUPHpT4X DzhMgRFXig0DbQMS0/s6orXbIqTuBEQ94tCzVXmhN0OrznewJ0lY4Z6jZoZ1JsHPQ/vt 3vZt1YEuqBc7w82GrBrI8ytXDoLDooGKX99ZKoOBTDUMHo34eMOrLNi83Zpn4g//Rifu 6nz6kwcoFkcSdkFp4PQoWywugB5JnfT5gcGo2iHLf1Xl9aSv6jXzxOt3zBVEE0HWhB4d 73pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y+wXREcz+G27txgq0Zyw9ZKW7U/CnCbXn9a5uKaTow4=; b=JBgvYUIJNo7P2mWLRupEi4cqLaYS6ErRRSQ/BBWoenbRJgfTWS6jua1dThs/ZKJ0oS dQD8bXETdjFcXjYUX0nrz7boKxWKa6AUVWvTEtOR/akQBupPT6P6E3G0ThQhQ4oCARM3 F1tOztFSzR40VtZtpRnoMA69d9E6bZKWe2aMPY3FV9EUOWhrt66wtDH3J3IYWsIj1kRp ttgchY6yTG0MPU6D0Zfid3AvNESE+dey1mRxLA0ooGq87UcErhR73AvLUq7ZRIp2yoXF vVkvmn/kiLus+Ja1zPJQMgo2VlxmhRlY8KGMwkCRKrGzqOFtqu9YsST4XxwaSbvDrgNz 7KWQ== X-Gm-Message-State: AOAM53054bObluGuKg+cj/vnur/hUNAKo2otCDUL+NDnICEJuFGYPz4k Y8owHCKNhUxp53QNbr9Z77rTlM05aYX9DbiXdeU= X-Google-Smtp-Source: ABdhPJzXeyziPzcq4JpGxW3I9kFzwjWdwL7P3QyxB1STXWYf8njaSFnyhyA9yfR83RpCDpgHnPbHNqzMX1C+6nkqUNg= X-Received: by 2002:a92:c102:: with SMTP id p2mr2587397ile.227.1616160059404; Fri, 19 Mar 2021 06:20:59 -0700 (PDT) MIME-Version: 1.0 References: <6834cb79431f394b05b06a26317799c9066ccd4f.1616002766.git.alistair.francis@wdc.com> <20c52b91-3ddb-f384-3094-7efb344ca5ef@linaro.org> In-Reply-To: <20c52b91-3ddb-f384-3094-7efb344ca5ef@linaro.org> From: Alistair Francis Date: Fri, 19 Mar 2021 09:19:11 -0400 Message-ID: Subject: Re: [PATCH v1 5/5] target/riscv: Use RiscVException enum for CSR access To: Richard Henderson Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::12a; envelope-from=alistair23@gmail.com; helo=mail-il1-x12a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Palmer Dabbelt , Bin Meng , Alistair Francis , "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Mar 18, 2021 at 9:25 AM Richard Henderson wrote: > > On 3/17/21 11:40 AM, Alistair Francis wrote: > > result = riscv_csrrw_debug(env, n - 32, &val, > > 0, 0); > > - if (result == 0) { > > + if (result != RISCV_EXCP_NONE) { > > This was intending == NONE. I.e. no exception raised, let gdb proceed. Good catch! Fixed. Alistair > > > r~