From: Alistair Francis <alistair.francis@xilinx.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
Peter Maydell <peter.maydell@linaro.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
Prasad J Pandit <pjp@fedoraproject.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address for APP CMD (CMD55)
Date: Wed, 31 Jan 2018 16:27:56 -0800 [thread overview]
Message-ID: <CAKmqyKNKeiOwz074788ZNGVpDWi8wt82Qyyzr_K-Q5odx-Mzig@mail.gmail.com> (raw)
In-Reply-To: <20180123033034.29493-13-f4bug@amsat.org>
On Mon, Jan 22, 2018 at 7:30 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Alistair
> ---
> hw/sd/sd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 434d1fbc47..b5c947df62 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -1394,6 +1394,11 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
> case sd_identification_state:
> case sd_inactive_state:
> return sd_illegal;
> + case sd_idle_state:
> + if (rca) {
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "SD: illegal RCA 0x%04x for APP_CMD\n", req.cmd);
> + }
> default:
> break;
> }
> --
> 2.15.1
>
>
next prev parent reply other threads:[~2018-02-01 0:28 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 3:30 [Qemu-devel] [PATCH v3 00/18] SDCard: bugfixes, support UHS-I (part 5) Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 01/18] sdcard: Don't always set the high capacity bit Philippe Mathieu-Daudé
2018-01-31 16:15 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 02/18] sdcard: update the CSD CRC register regardless the CSD structure version Philippe Mathieu-Daudé
2018-01-31 16:16 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 03/18] sdcard: fix the 'maximum data transfer rate' to 25MHz Philippe Mathieu-Daudé
2018-01-31 16:17 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 04/18] sdcard: clean the SCR register and add few comments Philippe Mathieu-Daudé
2018-01-31 16:18 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 05/18] sdcard: remove commands from unsupported old MMC specification Philippe Mathieu-Daudé
2018-01-31 16:59 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 06/18] sdcard: simplify using the ldst API Philippe Mathieu-Daudé
2018-02-08 23:46 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 07/18] sdcard: use the correct masked OCR in the R3 reply Philippe Mathieu-Daudé
2018-01-31 17:01 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 08/18] sdcard: use the registerfields API for the CARD_STATUS register masks Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 09/18] sdcard: handles more commands in SPI mode Philippe Mathieu-Daudé
2018-02-01 0:11 ` Alistair Francis
2018-02-01 7:39 ` Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 10/18] sdcard: handle CMD54 (SDIO) Philippe Mathieu-Daudé
2018-02-01 0:12 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 11/18] sdcard: check the card is in correct state for APP CMD (CMD55) Philippe Mathieu-Daudé
2018-02-01 0:27 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 12/18] sdcard: warn if host uses an incorrect address " Philippe Mathieu-Daudé
2018-02-01 0:27 ` Alistair Francis [this message]
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 13/18] sdcard: simplify SEND_IF_COND (CMD8) Philippe Mathieu-Daudé
2018-02-01 0:33 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 14/18] sdcard: simplify SD_SEND_OP_COND (ACMD41) Philippe Mathieu-Daudé
2018-02-02 0:55 ` Alistair Francis
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 15/18] sdcard: add SD SEND_TUNING_BLOCK (CMD19) Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 16/18] sdcard: add a 'uhs' property, update the OCR register ACCEPT_SWITCH_1V8 bit Philippe Mathieu-Daudé
2018-01-25 10:30 ` Philippe Mathieu-Daudé
2018-01-25 10:37 ` Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 17/18] sdcard: implement the UHS-I SWITCH_FUNCTION entries (Spec v3) Philippe Mathieu-Daudé
2018-01-23 3:30 ` [Qemu-devel] [PATCH v3 18/18] sdcard: add an enum for the SD PHY Spec version Philippe Mathieu-Daudé
2018-02-01 0:41 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNKeiOwz074788ZNGVpDWi8wt82Qyyzr_K-Q5odx-Mzig@mail.gmail.com \
--to=alistair.francis@xilinx.com \
--cc=crosthwaite.peter@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).