Re: [PATCH] include virtualization mode as part of priv

[Alistair Francis <alistair23@gmail.com>]

On Thu, Nov 28, 2024 at 2:05 PM Yanfeng <yfliu2008@qq.com> wrote:
>
> Alistair.
>
> My initial `git send-email" on Ubuntu 22.04 wasn't lukcy:
>
> ```shell
> $ git send-email
> git: 'send-email' is not a git command. See 'git --help'.
> ```
>
> I need time to find a solution.

You will need to install git-send-email (or something like that)

>
> As for seperate `virt` thing, my concern is that though the V and P status looks
> orthogonal, they are not so independent (e.g. `P=3` implies `V=0`). Having them
> in one `priv` register tells user that that they should be operated together
> using one command.

True, but how can a user know what bit 8 means?

Alistair

>
> On Thu, 2024-11-28 at 12:43 +1000, Alistair Francis wrote:
> > On Thu, Nov 28, 2024 at 11:43 AM Yanfeng <yfliu2008@qq.com> wrote:
> > >
> > > On Thu, 2024-11-28 at 10:39 +1000, Alistair Francis wrote:
> > > > On Thu, Nov 28, 2024 at 12:09 AM Yanfeng <yfliu2008@qq.com> wrote:
> > > > >
> > > > >
> > > > > When debugging hypervisor extension based programs, it is convenient to
> > > > > see
> > > > > the
> > > > > current virtualization mode from GDB debugger.
> > > > >
> > > > > This patch shares the virtualization mode as part of the existing "priv"
> > > > > virtual
> > > > > register, or more specifically via bit(8).
> > > >
> > > > Interesting concept. This seems fine to me, I don't think this will
> > > > break any existing user.
> > > >
> > > > Another option though is to add a "virt" virtual register, which might
> > > > be easier for people to figure out as it isn't obvious from GDB what
> > > > bit 8 means. That might be a better approach as then it's really clear
> > > > what the register means.
> > > >
> > > > >
> > > > >
> > > > > > From 0d82561b11e1c2835f14ba5460cfff52f0087530 Mon Sep 17 00:00:00 2001
> > > > > From: Yanfeng Liu <yfliu2008@qq.com>
> > > > > Date: Mon, 18 Nov 2024 08:03:15 +0800
> > > > > Subject: [PATCH] riscv/gdb: share virt mode via priv register
> > > >
> > > > It seems like something strange happened when you submitted the patch.
> > > > Can you fix this up?
> > > >
> > > I prepared a patch file via the following steps:
> > >
> > >  - Did  `git format-patch --stdout -1 > /tmp/patch`,
> > >  - Pasted the /tmp/patch content to email composer window,
> > >  - Filled in email receipts, subject line and a few lines before the patch
> > > context in composer window.
> >
> > You should use `git send-email` instead, see the QEMU documentation
> > for more details:
> > https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches
> >
> > >
> > > I am wondering if the lines added before the formatted patch content in last
> > > step caused trouble?
> > > When resending email, should I use [patch v2] in subject line? I guess it is
> > > unnecessary as it is the same patch.
> >
> > Ideally I think a "virt" virtual register would be a better approach,
> > so if you could do that instead and send a v2 that would be great :)
> >
> > Alistair
>