From: Alistair Francis <alistair23@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Palmer Dabbelt <palmer@sifive.com>,
"qemu-riscv@nongnu.org" <qemu-riscv@nongnu.org>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Anup Patel <Anup.Patel@wdc.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Anup Patel <anup@brainfault.org>
Subject: Re: [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine
Date: Mon, 4 Nov 2019 14:38:20 -0800 [thread overview]
Message-ID: <CAKmqyKNUsZBt=Pa3TAkGUP_DFThWSs2nwjXMJSbQ5r927jtnkQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9bV=-t0+ro6rxu7Atodj6J78aT1aMnz9bjaqyfLDV3_w@mail.gmail.com>
On Sat, Nov 2, 2019 at 3:37 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 29 Oct 2019 at 13:25, Alistair Francis <alistair23@gmail.com> wrote:
> >
> > On Fri, Oct 25, 2019 at 6:28 AM Anup Patel <Anup.Patel@wdc.com> wrote:
> > >
> > > This series adds RTC device to QEMU RISC-V virt machine. We have
> > > selected Goldfish RTC device model for this. It's a pretty simple
> > > synthetic device with few MMIO registers and no dependency external
> > > clock. The driver for Goldfish RTC is already available in Linux so
> > > we just need to enable it in Kconfig for RISCV and also update Linux
> > > defconfigs.
> > >
> > > We have tested this series with Linux-5.4-rc4 plus defconfig changes
> > > available in 'goldfish_rtc_v2' branch of:
> > > https://github.com/avpatel/linux.git
> >
> > @Peter Maydell this has been reviewed, do you mind taking this in you
> > next PR? I don't see a maintainer for hw/rtc.
>
> Generally devices used by a single architecture should
> go via the tree of the maintainer who handles that
> architecture -- in this case that's riscv. (The reason
> is that it's only riscv folks who can test whether the
> device works in the machine model, and only riscv
> folks who can reasonably review whether the device
> is the right way of implementing the functionality for
> them.)
Makes sense
Alistair
>
> thanks
> -- PMM
next prev parent reply other threads:[~2019-11-04 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 4:28 [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine Anup Patel
2019-10-25 4:28 ` [PATCH v5 1/2] hw: rtc: Add Goldfish RTC device Anup Patel
2019-10-29 13:22 ` Alistair Francis
2019-10-25 4:28 ` [PATCH v5 2/2] riscv: virt: Use " Anup Patel
2019-10-29 13:24 ` [PATCH v5 0/2] RTC support for QEMU RISC-V virt machine Alistair Francis
2019-11-01 15:40 ` Anup Patel
2019-11-01 23:14 ` Palmer Dabbelt
2019-11-03 7:12 ` Anup Patel
2019-11-04 22:35 ` Alistair Francis
2019-11-02 10:37 ` Peter Maydell
2019-11-04 22:38 ` Alistair Francis [this message]
2019-11-05 18:43 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKNUsZBt=Pa3TAkGUP_DFThWSs2nwjXMJSbQ5r927jtnkQ@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).