qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 1/4] configure: Do not build libfdt is not required
Date: Fri, 10 Jan 2020 18:04:19 +0800	[thread overview]
Message-ID: <CAKmqyKNXE7fcrXobJnWqD+rnCJcOy5aEStbkZDBhU07JBJ1oVQ@mail.gmail.com> (raw)
In-Reply-To: <20200109153939.27173-2-philmd@redhat.com>

On Thu, Jan 9, 2020 at 11:40 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> We only require libfdt for system emulation, in a small set
> of architecture:
>
> 4077  # fdt support is mandatory for at least some target architectures,
> 4078  # so insist on it if we're building those system emulators.
> 4079  fdt_required=no
> 4080  for target in $target_list; do
> 4081    case $target in
> 4082      aarch64*-softmmu|arm*-softmmu|ppc*-softmmu|microblaze*-softmmu|mips64el-softmmu|riscv*-softmmu)
> 4083        fdt_required=yes
>
> Do not build libfdt if we did not manually specified --enable-fdt.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  configure | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 0ce2c0354a..266a8386d1 100755
> --- a/configure
> +++ b/configure
> @@ -4092,6 +4092,8 @@ if test "$fdt_required" = "yes"; then
>        "targets which need it (by specifying a cut down --target-list)."
>    fi
>    fdt=yes
> +elif test "$fdt" != "yes" ; then
> +  fdt=no
>  fi
>
>  if test "$fdt" != "no" ; then
> --
> 2.21.1
>
>


  parent reply	other threads:[~2020-01-10 10:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09 15:39 [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user) Philippe Mathieu-Daudé
2020-01-09 15:39 ` [PATCH 1/4] configure: Do not build libfdt is not required Philippe Mathieu-Daudé
2020-01-09 16:33   ` Thomas Huth
2020-01-10 10:04   ` Alistair Francis [this message]
2020-01-09 15:39 ` [PATCH 2/4] Makefile: Clarify all the codebase requires qom/ objects Philippe Mathieu-Daudé
2020-01-10  8:13   ` Thomas Huth
2020-01-09 15:39 ` [PATCH 3/4] Makefile: Restrict system emulation and tools objects Philippe Mathieu-Daudé
2020-01-10  8:14   ` Thomas Huth
2020-01-10  8:25     ` Philippe Mathieu-Daudé
2020-01-10  8:34       ` Thomas Huth
2020-01-09 15:39 ` [PATCH 4/4] Makefile: Remove unhelpful comment Philippe Mathieu-Daudé
2020-01-10  8:15   ` Thomas Huth
2020-01-10  8:35 ` [PATCH 0/4] buildsys: Build quicker (mostly tools and linux-user) Laurent Vivier
2020-01-10  9:17   ` Philippe Mathieu-Daudé
2020-01-10 14:03     ` Laurent Vivier
2020-01-10 16:41       ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKNXE7fcrXobJnWqD+rnCJcOy5aEStbkZDBhU07JBJ1oVQ@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).