From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>,
"Bin Meng" <bin.meng@windriver.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Alistair Francis" <alistair.francis@wdc.com>
Subject: Re: [PATCH 12/22] hw/sd: sd.h: Cosmetic change of using spaces
Date: Wed, 13 Jan 2021 09:59:24 -0800 [thread overview]
Message-ID: <CAKmqyKNYtSvFybFeSC7mtWSibBaDS0bhMnFvgkBNHAY1X-aOjQ@mail.gmail.com> (raw)
In-Reply-To: <20201231113010.27108-13-bmeng.cn@gmail.com>
On Thu, Dec 31, 2020 at 3:46 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> QEMU conding convention prefers spaces over tabs.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> include/hw/sd/sd.h | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h
> index 59d108d453..05ef9b73e5 100644
> --- a/include/hw/sd/sd.h
> +++ b/include/hw/sd/sd.h
> @@ -33,27 +33,27 @@
> #include "hw/qdev-core.h"
> #include "qom/object.h"
>
> -#define OUT_OF_RANGE (1 << 31)
> -#define ADDRESS_ERROR (1 << 30)
> -#define BLOCK_LEN_ERROR (1 << 29)
> -#define ERASE_SEQ_ERROR (1 << 28)
> -#define ERASE_PARAM (1 << 27)
> -#define WP_VIOLATION (1 << 26)
> -#define CARD_IS_LOCKED (1 << 25)
> -#define LOCK_UNLOCK_FAILED (1 << 24)
> -#define COM_CRC_ERROR (1 << 23)
> -#define ILLEGAL_COMMAND (1 << 22)
> -#define CARD_ECC_FAILED (1 << 21)
> -#define CC_ERROR (1 << 20)
> -#define SD_ERROR (1 << 19)
> -#define CID_CSD_OVERWRITE (1 << 16)
> -#define WP_ERASE_SKIP (1 << 15)
> -#define CARD_ECC_DISABLED (1 << 14)
> -#define ERASE_RESET (1 << 13)
> -#define CURRENT_STATE (7 << 9)
> -#define READY_FOR_DATA (1 << 8)
> -#define APP_CMD (1 << 5)
> -#define AKE_SEQ_ERROR (1 << 3)
> +#define OUT_OF_RANGE (1 << 31)
> +#define ADDRESS_ERROR (1 << 30)
> +#define BLOCK_LEN_ERROR (1 << 29)
> +#define ERASE_SEQ_ERROR (1 << 28)
> +#define ERASE_PARAM (1 << 27)
> +#define WP_VIOLATION (1 << 26)
> +#define CARD_IS_LOCKED (1 << 25)
> +#define LOCK_UNLOCK_FAILED (1 << 24)
> +#define COM_CRC_ERROR (1 << 23)
> +#define ILLEGAL_COMMAND (1 << 22)
> +#define CARD_ECC_FAILED (1 << 21)
> +#define CC_ERROR (1 << 20)
> +#define SD_ERROR (1 << 19)
> +#define CID_CSD_OVERWRITE (1 << 16)
> +#define WP_ERASE_SKIP (1 << 15)
> +#define CARD_ECC_DISABLED (1 << 14)
> +#define ERASE_RESET (1 << 13)
> +#define CURRENT_STATE (7 << 9)
> +#define READY_FOR_DATA (1 << 8)
> +#define APP_CMD (1 << 5)
> +#define AKE_SEQ_ERROR (1 << 3)
>
> enum SDPhySpecificationVersion {
> SD_PHY_SPECv1_10_VERS = 1,
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-01-13 18:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 11:29 [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support Bin Meng
2020-12-31 11:29 ` [PATCH 01/22] hw/block: m25p80: Add ISSI SPI flash support Bin Meng
2021-01-04 16:00 ` Francisco Iglesias
2021-01-04 23:30 ` Bin Meng
2020-12-31 11:29 ` [PATCH 02/22] hw/block: m25p80: Add various ISSI flash information Bin Meng
2021-01-05 21:16 ` Alistair Francis
2020-12-31 11:29 ` [PATCH 03/22] hw/sd: ssi-sd: Fix incorrect card response sequence Bin Meng
2021-01-02 13:49 ` Pragnesh Patel
2020-12-31 11:29 ` [PATCH 04/22] hw/sd: sd: Support CMD59 for SPI mode Bin Meng
2021-01-02 13:50 ` Pragnesh Patel
2020-12-31 11:29 ` [PATCH 05/22] hw/sd: sd: Drop sd_crc16() Bin Meng
2021-01-02 13:53 ` Pragnesh Patel
2021-01-14 11:51 ` Philippe Mathieu-Daudé
2020-12-31 11:29 ` [PATCH 06/22] util: Add CRC16 (CCITT) calculation routines Bin Meng
2021-01-14 20:20 ` Alistair Francis
2020-12-31 11:29 ` [PATCH 07/22] hw/sd: ssi-sd: Suffix a data block with CRC16 Bin Meng
2021-01-13 16:54 ` Alistair Francis
2020-12-31 11:29 ` [PATCH 08/22] hw/sd: ssi-sd: Support multiple block read (CMD18) Bin Meng
2021-01-13 16:59 ` Alistair Francis
2020-12-31 11:29 ` [PATCH 09/22] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer Bin Meng
2021-01-13 17:00 ` Alistair Francis
2021-01-14 11:40 ` Philippe Mathieu-Daudé
2020-12-31 11:29 ` [PATCH 10/22] hw/sd: sd: Remove duplicated codes in single/multiple block read/write Bin Meng
2021-01-13 17:02 ` Alistair Francis
2020-12-31 11:29 ` [PATCH 11/22] hw/sd: sd: Allow single/multiple block write for SPI mode Bin Meng
2021-01-13 17:03 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 12/22] hw/sd: sd.h: Cosmetic change of using spaces Bin Meng
2021-01-13 17:59 ` Alistair Francis [this message]
2020-12-31 11:30 ` [PATCH 13/22] hw/sd: Introduce receive_ready() callback Bin Meng
2021-01-13 17:22 ` Alistair Francis
2021-01-14 11:44 ` Philippe Mathieu-Daudé
2020-12-31 11:30 ` [PATCH 14/22] hw/sd: ssi-sd: Support single block write Bin Meng
2021-01-13 18:07 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 15/22] hw/sd: ssi-sd: Support multiple " Bin Meng
2021-01-13 18:11 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 16/22] hw/ssi: Add SiFive SPI controller support Bin Meng
2021-01-13 18:28 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 17/22] hw/riscv: sifive_u: Add QSPI0 controller and connect a flash Bin Meng
2021-01-13 18:30 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 18/22] hw/riscv: sifive_u: Add QSPI2 controller and connect an SD card Bin Meng
2021-01-13 18:32 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 19/22] hw/riscv: sifive_u: Change SIFIVE_U_GEM_IRQ to decimal value Bin Meng
2021-01-13 18:33 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 20/22] docs/system: Sort targets in alphabetical order Bin Meng
2021-01-13 18:33 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 21/22] docs/system: Add RISC-V documentation Bin Meng
2021-01-14 0:11 ` Alistair Francis
2020-12-31 11:30 ` [PATCH 22/22] docs/system: riscv: Add documentation for sifive_u machine Bin Meng
2021-01-14 0:11 ` Alistair Francis
2021-01-02 12:26 ` [PATCH 00/22] hw/riscv: sifive_u: Add missing SPI support Pragnesh Patel
2021-01-02 13:15 ` Bin Meng
2021-01-02 13:30 ` Pragnesh Patel
2021-01-02 13:36 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNYtSvFybFeSC7mtWSibBaDS0bhMnFvgkBNHAY1X-aOjQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=f4bug@amsat.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).