From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50273) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI3AI-0007R3-5w for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bI3AF-0006j7-06 for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:37 -0400 Received: from mail-ob0-x242.google.com ([2607:f8b0:4003:c01::242]:34341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bI3AE-0006j1-PX for qemu-devel@nongnu.org; Tue, 28 Jun 2016 20:15:34 -0400 Received: by mail-ob0-x242.google.com with SMTP id s7so422380obo.1 for ; Tue, 28 Jun 2016 17:15:34 -0700 (PDT) MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: <1465835259-21449-2-git-send-email-fred.konrad@greensocs.com> References: <1465835259-21449-1-git-send-email-fred.konrad@greensocs.com> <1465835259-21449-2-git-send-email-fred.konrad@greensocs.com> From: Alistair Francis Date: Tue, 28 Jun 2016 17:15:04 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [RFC PATCH 01/11] qemu-clk: introduce qemu-clk qom object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= Cc: "qemu-devel@nongnu.org Developers" , Edgar Iglesias , Peter Maydell , Mark Burton , Alistair Francis On Mon, Jun 13, 2016 at 9:27 AM, wrote: > From: KONRAD Frederic > > This introduces qemu-clk qom object. > > Signed-off-by: KONRAD Frederic > --- > Makefile.objs | 1 + > include/qemu/qemu-clock.h | 40 ++++++++++++++++++++++++++++++++++++++++ > qemu-clock.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 88 insertions(+) > create mode 100644 include/qemu/qemu-clock.h > create mode 100644 qemu-clock.c > > diff --git a/Makefile.objs b/Makefile.objs > index 61f4bf4..2284ef5 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -77,6 +77,7 @@ common-obj-y += backends/ > common-obj-$(CONFIG_SECCOMP) += qemu-seccomp.o > > common-obj-$(CONFIG_FDT) += device_tree.o > +common-obj-y += qemu-clock.o > > ###################################################################### > # qapi > diff --git a/include/qemu/qemu-clock.h b/include/qemu/qemu-clock.h > new file mode 100644 > index 0000000..e7acd68 > --- /dev/null > +++ b/include/qemu/qemu-clock.h > @@ -0,0 +1,40 @@ > +/* > + * QEMU Clock > + * > + * Copyright (C) 2016 : GreenSocs Ltd > + * http://www.greensocs.com/ , email: info@greensocs.com > + * > + * Frederic Konrad > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation, either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + * > + */ > + > +#ifndef QEMU_CLOCK_H > +#define QEMU_CLOCK_H > + > +#include "qemu/osdep.h" > +#include "qom/object.h" > + > +#define TYPE_CLOCK "qemu-clk" > +#define QEMU_CLOCK(obj) OBJECT_CHECK(struct qemu_clk, (obj), TYPE_CLOCK) > + > +typedef struct qemu_clk { > + /*< private >*/ > + Object parent_obj; > +} *qemu_clk; > + > +#endif /* QEMU_CLOCK_H */ > + > + > diff --git a/qemu-clock.c b/qemu-clock.c > new file mode 100644 > index 0000000..4a47fb4 > --- /dev/null > +++ b/qemu-clock.c > @@ -0,0 +1,47 @@ > +/* > + * QEMU Clock > + * > + * Copyright (C) 2016 : GreenSocs Ltd > + * http://www.greensocs.com/ , email: info@greensocs.com > + * > + * Frederic Konrad > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation, either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, see . > + * > + */ > + > +#include "qemu/qemu-clock.h" > +#include "hw/hw.h" I'm pretty sure every file should start with osdep now. > + > +/* #define DEBUG_QEMU_CLOCK */ This shouldn't be here. Thanks, Alistair > + > +#ifdef DEBUG_QEMU_CLOCK > +#define DPRINTF(fmt, ...) \ > +do { printf("qemu-clock: " fmt , ## __VA_ARGS__); } while (0) > +#else > +#define DPRINTF(fmt, ...) do { } while (0) > +#endif > + > +static const TypeInfo qemu_clk_info = { > + .name = TYPE_CLOCK, > + .parent = TYPE_OBJECT, > + .instance_size = sizeof(struct qemu_clk), > +}; > + > +static void qemu_clk_register_types(void) > +{ > + type_register_static(&qemu_clk_info); > +} > + > +type_init(qemu_clk_register_types); > -- > 2.5.5 > >