From: Alistair Francis <alistair23@gmail.com>
To: Weiwei Li <liweiwei@iscas.ac.cn>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
"Bin Meng" <bin.meng@windriver.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
wangjunqiang <wangjunqiang@iscas.ac.cn>,
"Wei Wu (吴伟)" <lazyparser@gmail.com>
Subject: Re: [PATCH V3 0/6] Improve the U/S/H extension related check
Date: Tue, 19 Jul 2022 10:23:40 +1000 [thread overview]
Message-ID: <CAKmqyKNivL5AVHSbL8JuaxOv9fv3y0Mo3TN0TpPB6Rt7+XWbvw@mail.gmail.com> (raw)
In-Reply-To: <20220718130955.11899-1-liweiwei@iscas.ac.cn>
On Mon, Jul 18, 2022 at 11:10 PM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> This patchset tries to improve the U/S/H related check:
> * add check for the supported privilege modes conbinations: only supporting M,
> S mode is not a suggested combination
> * add check for "H extension depends on I extension"
> * add check for "H extension implicitly requires S mode"
> * add check for csrs only existed when U mode is supported
> * fix and simplify the checks in hmode/hmode32
>
> Any suggestions are welcome.
>
> v3:
> * Fix the issues suggested by Andrew Jones in commit messages
>
> v2:
> * update patch 3 to make the newlines start at the same position as above line
> * update patch 5 to add check for "H extension implicitly requires S mode"
>
> Weiwei Li (6):
> target/riscv: Add check for supported privilege mode combinations
> target/riscv: H extension depends on I extension
> target/riscv: Fix checkpatch warning may triggered in csr_ops table
> target/riscv: Add check for csrs existed with U extension
> target/riscv: Fix checks in hmode/hmode32
> target/riscv: Simplify the check in hmode to resue the check in
> riscv_csrrw_check
Thanks!
Applied to riscv-to-apply.next
Alistair
>
> target/riscv/cpu.c | 17 ++
> target/riscv/csr.c | 490 ++++++++++++++++++++++++---------------------
> 2 files changed, 278 insertions(+), 229 deletions(-)
>
> --
> 2.17.1
>
>
prev parent reply other threads:[~2022-07-19 0:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 13:09 [PATCH V3 0/6] Improve the U/S/H extension related check Weiwei Li
2022-07-18 13:09 ` [PATCH V3 1/6] target/riscv: Add check for supported privilege mode combinations Weiwei Li
2022-07-18 13:09 ` [PATCH V3 2/6] target/riscv: H extension depends on I extension Weiwei Li
2022-07-18 13:09 ` [PATCH V3 3/6] target/riscv: Fix checkpatch warning may triggered in csr_ops table Weiwei Li
2022-07-18 13:09 ` [PATCH V3 4/6] target/riscv: Add check for csrs existed with U extension Weiwei Li
2022-07-18 13:09 ` [PATCH V3 5/6] target/riscv: Fix checks in hmode/hmode32 Weiwei Li
2022-07-18 23:10 ` Alistair Francis
2022-07-18 13:09 ` [PATCH V3 6/6] target/riscv: Simplify the check in hmode to resue the check in riscv_csrrw_check Weiwei Li
2022-07-18 13:47 ` Andrew Jones
2022-07-18 14:31 ` Weiwei Li
2022-07-19 0:23 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKNivL5AVHSbL8JuaxOv9fv3y0Mo3TN0TpPB6Rt7+XWbvw@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).