qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Xinhao Zhang <zhangxinhao1@huawei.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	alex.chen@huawei.com, Alistair Francis <Alistair.Francis@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	"dengkai \(A\)" <dengkai1@huawei.com>
Subject: Re: [PATCH] target/riscv/csr.c : add space before the open parenthesis '('
Date: Mon, 2 Nov 2020 09:39:43 -0800	[thread overview]
Message-ID: <CAKmqyKNiyTTWHOdgxsoQoFoDX7XN2Vdjz7oXyMtx8JEXiFwpcw@mail.gmail.com> (raw)
In-Reply-To: <20201030004815.4172849-1-zhangxinhao1@huawei.com>

On Thu, Oct 29, 2020 at 5:56 PM Xinhao Zhang <zhangxinhao1@huawei.com> wrote:
>
> Fix code style. Space required before the open parenthesis '('.
>
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>
> Reported-by: Euler Robot <euler.robot@huawei.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/csr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index aaef6c6f20..e8b149f0d2 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -881,7 +881,7 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)
>          if (env->priv == PRV_S && get_field(env->mstatus, MSTATUS_TVM)) {
>              return -RISCV_EXCP_ILLEGAL_INST;
>          } else {
> -            if((val ^ env->satp) & SATP_ASID) {
> +            if ((val ^ env->satp) & SATP_ASID) {
>                  tlb_flush(env_cpu(env));
>              }
>              env->satp = val;
> --
> 2.29.0-rc1
>
>


  parent reply	other threads:[~2020-11-02 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-30  0:48 [PATCH] target/riscv/csr.c : add space before the open parenthesis '(' Xinhao Zhang
2020-10-30  9:14 ` Bin Meng
2020-11-02 17:39 ` Alistair Francis [this message]
2020-11-03 15:18 ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKNiyTTWHOdgxsoQoFoDX7XN2Vdjz7oXyMtx8JEXiFwpcw@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=alex.chen@huawei.com \
    --cc=dengkai1@huawei.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    --cc=zhangxinhao1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).