* [PATCH] target/riscv/csr.c : add space before the open parenthesis '('
@ 2020-10-30 0:48 Xinhao Zhang
2020-10-30 9:14 ` Bin Meng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xinhao Zhang @ 2020-10-30 0:48 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: sagark, qemu-trivial, kbastian, alex.chen, Alistair.Francis,
palmer, dengkai1
Fix code style. Space required before the open parenthesis '('.
Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
Signed-off-by: Kai Deng <dengkai1@huawei.com>
Reported-by: Euler Robot <euler.robot@huawei.com>
---
target/riscv/csr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/csr.c b/target/riscv/csr.c
index aaef6c6f20..e8b149f0d2 100644
--- a/target/riscv/csr.c
+++ b/target/riscv/csr.c
@@ -881,7 +881,7 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)
if (env->priv == PRV_S && get_field(env->mstatus, MSTATUS_TVM)) {
return -RISCV_EXCP_ILLEGAL_INST;
} else {
- if((val ^ env->satp) & SATP_ASID) {
+ if ((val ^ env->satp) & SATP_ASID) {
tlb_flush(env_cpu(env));
}
env->satp = val;
--
2.29.0-rc1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] target/riscv/csr.c : add space before the open parenthesis '('
2020-10-30 0:48 [PATCH] target/riscv/csr.c : add space before the open parenthesis '(' Xinhao Zhang
@ 2020-10-30 9:14 ` Bin Meng
2020-11-02 17:39 ` Alistair Francis
2020-11-03 15:18 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2020-10-30 9:14 UTC (permalink / raw)
To: Xinhao Zhang
Cc: open list:RISC-V, Sagar Karandikar, QEMU Trivial,
Bastian Koppelmann, qemu-devel@nongnu.org Developers, alex.chen,
Alistair Francis, Palmer Dabbelt, dengkai1
On Fri, Oct 30, 2020 at 8:58 AM Xinhao Zhang <zhangxinhao1@huawei.com> wrote:
>
> Fix code style. Space required before the open parenthesis '('.
>
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> ---
> target/riscv/csr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Bin Meng <bin.meng@windriver.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/riscv/csr.c : add space before the open parenthesis '('
2020-10-30 0:48 [PATCH] target/riscv/csr.c : add space before the open parenthesis '(' Xinhao Zhang
2020-10-30 9:14 ` Bin Meng
@ 2020-11-02 17:39 ` Alistair Francis
2020-11-03 15:18 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2020-11-02 17:39 UTC (permalink / raw)
To: Xinhao Zhang
Cc: open list:RISC-V, Sagar Karandikar, QEMU Trivial,
Bastian Koppelmann, qemu-devel@nongnu.org Developers, alex.chen,
Alistair Francis, Palmer Dabbelt, dengkai (A)
On Thu, Oct 29, 2020 at 5:56 PM Xinhao Zhang <zhangxinhao1@huawei.com> wrote:
>
> Fix code style. Space required before the open parenthesis '('.
>
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>
> Reported-by: Euler Robot <euler.robot@huawei.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/csr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index aaef6c6f20..e8b149f0d2 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -881,7 +881,7 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)
> if (env->priv == PRV_S && get_field(env->mstatus, MSTATUS_TVM)) {
> return -RISCV_EXCP_ILLEGAL_INST;
> } else {
> - if((val ^ env->satp) & SATP_ASID) {
> + if ((val ^ env->satp) & SATP_ASID) {
> tlb_flush(env_cpu(env));
> }
> env->satp = val;
> --
> 2.29.0-rc1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] target/riscv/csr.c : add space before the open parenthesis '('
2020-10-30 0:48 [PATCH] target/riscv/csr.c : add space before the open parenthesis '(' Xinhao Zhang
2020-10-30 9:14 ` Bin Meng
2020-11-02 17:39 ` Alistair Francis
@ 2020-11-03 15:18 ` Alistair Francis
2 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2020-11-03 15:18 UTC (permalink / raw)
To: Xinhao Zhang
Cc: open list:RISC-V, Sagar Karandikar, QEMU Trivial,
Bastian Koppelmann, qemu-devel@nongnu.org Developers, alex.chen,
Alistair Francis, Palmer Dabbelt, dengkai (A)
On Thu, Oct 29, 2020 at 5:56 PM Xinhao Zhang <zhangxinhao1@huawei.com> wrote:
>
> Fix code style. Space required before the open parenthesis '('.
>
> Signed-off-by: Xinhao Zhang <zhangxinhao1@huawei.com>
> Signed-off-by: Kai Deng <dengkai1@huawei.com>
> Reported-by: Euler Robot <euler.robot@huawei.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> target/riscv/csr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index aaef6c6f20..e8b149f0d2 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -881,7 +881,7 @@ static int write_satp(CPURISCVState *env, int csrno, target_ulong val)
> if (env->priv == PRV_S && get_field(env->mstatus, MSTATUS_TVM)) {
> return -RISCV_EXCP_ILLEGAL_INST;
> } else {
> - if((val ^ env->satp) & SATP_ASID) {
> + if ((val ^ env->satp) & SATP_ASID) {
> tlb_flush(env_cpu(env));
> }
> env->satp = val;
> --
> 2.29.0-rc1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-03 15:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-30 0:48 [PATCH] target/riscv/csr.c : add space before the open parenthesis '(' Xinhao Zhang
2020-10-30 9:14 ` Bin Meng
2020-11-02 17:39 ` Alistair Francis
2020-11-03 15:18 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).