From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CCBC4338F for ; Thu, 19 Aug 2021 22:52:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91A0360ED5 for ; Thu, 19 Aug 2021 22:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 91A0360ED5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGqtJ-0003SR-MN for qemu-devel@archiver.kernel.org; Thu, 19 Aug 2021 18:52:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGqsG-0002Qq-Lg; Thu, 19 Aug 2021 18:51:00 -0400 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]:44547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGqsE-0007It-CW; Thu, 19 Aug 2021 18:51:00 -0400 Received: by mail-io1-xd2e.google.com with SMTP id g9so9773567ioq.11; Thu, 19 Aug 2021 15:50:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LOftkpDKk6mQohXTsd7ZQ8wmGXsKNS5uiJKFMfnXOSw=; b=Y7P0vhzAlSZYQaPbEgUsQe4NGSD3SodzaPROtQNWf4J0NjWRbcRtkNpYTG6dtOrqcm Eufs54Qa3028TTonK5ulXGmqf2JiGuAFQhi7wjBzciXrghKsEZNCZYxtFkvKQTt0cZj1 XIm6vNXEhHYbTldGCC3N+MyGCfidn1QTjWTt7eDJPS+MPvbicf5pht9QorThbSdOfjo9 /2113G48fvW5P7Lxmd9M5L/S2FA+UGGMTvpFM19W+oWUp5zXDAx/AV07x1mwhGOC02nD oUnNaqv8xBS/logv8zpf8WC7oZzBi/KOx3dNMMf1XnB07h3p2N4mutx2+YIO9B5yfRlZ Kzzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LOftkpDKk6mQohXTsd7ZQ8wmGXsKNS5uiJKFMfnXOSw=; b=YxUEDsutVYZ9OPTfdtbqEckghPZ1VSNfTR6Re4pdCb9obNLxAo70fXHPbcio7rWXqE BhqCyWxreTHMn+23h82FWxQCqsxdPIuzydoVRdoXpZjnX4gP8IkWvbtUR0RCuapVgEsg YRKIf0xetKo0nc868FXTsDTbN4qvs7yLa2TTZxBN9bl9m1zJVGRwXSKArY6OqADpyGlq HPZPDCjt0/sFbDMKYK555D+4pkkqlG7g5UTSZxPxKM2wuGgBRMGvVU4ae130FzRJ1qjA cpFdK0DpMNbFOupzvH8CJ/TwpBZHz4AARj2Byv6DRcSrF59apkgzW5KOe3uM9svMaFde yn5g== X-Gm-Message-State: AOAM5300H8mm5MebCxOk/e94NKFpDo10thBcB9W08YG99wMe6BXcKMbJ SzPmScuGuc6RvTtuOuG9MWlPtqkmhBDlKzSuHNc= X-Google-Smtp-Source: ABdhPJxbxmTeV19i0+RNextvBpmE2qN/CvfyYnT/Ww6WtTJpfI9NaV3GeTg3pXpyV7vDll2dqU1Y8SU/Mmc6u2GgyVQ= X-Received: by 2002:a6b:610d:: with SMTP id v13mr13145030iob.42.1629413455982; Thu, 19 Aug 2021 15:50:55 -0700 (PDT) MIME-Version: 1.0 References: <20210819163422.2863447-1-philmd@redhat.com> <20210819163422.2863447-2-philmd@redhat.com> In-Reply-To: <20210819163422.2863447-2-philmd@redhat.com> From: Alistair Francis Date: Fri, 20 Aug 2021 08:50:30 +1000 Message-ID: Subject: Re: [PATCH v2 1/4] hw/arm/xlnx-zynqmp: Realize qspi controller *after* qspi_dma To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::d2e; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E. Iglesias" , qemu-arm , "qemu-devel@nongnu.org Developers" , Alistair Francis , Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Aug 20, 2021 at 2:35 AM Philippe Mathieu-Daud=C3=A9 wrote: > > If we link QOM object (a) as a property of QOM object (b), > we must set the property *before* (b) is realized. > > Move QSPI realization *after* QSPI DMA. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-zynqmp.c | 42 ++++++++++++++++++++---------------------- > 1 file changed, 20 insertions(+), 22 deletions(-) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index 3597e8db4de..9724978761b 100644 > --- a/hw/arm/xlnx-zynqmp.c > +++ b/hw/arm/xlnx-zynqmp.c > @@ -570,26 +570,6 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Er= ror **errp) > g_free(bus_name); > } > > - if (!sysbus_realize(SYS_BUS_DEVICE(&s->qspi), errp)) { > - return; > - } > - sysbus_mmio_map(SYS_BUS_DEVICE(&s->qspi), 0, QSPI_ADDR); > - sysbus_mmio_map(SYS_BUS_DEVICE(&s->qspi), 1, LQSPI_ADDR); > - sysbus_connect_irq(SYS_BUS_DEVICE(&s->qspi), 0, gic_spi[QSPI_IRQ]); > - > - for (i =3D 0; i < XLNX_ZYNQMP_NUM_QSPI_BUS; i++) { > - gchar *bus_name; > - gchar *target_bus; > - > - /* Alias controller SPI bus to the SoC itself */ > - bus_name =3D g_strdup_printf("qspi%d", i); > - target_bus =3D g_strdup_printf("spi%d", i); > - object_property_add_alias(OBJECT(s), bus_name, > - OBJECT(&s->qspi), target_bus); > - g_free(bus_name); > - g_free(target_bus); > - } > - > if (!sysbus_realize(SYS_BUS_DEVICE(&s->dp), errp)) { > return; > } > @@ -646,8 +626,26 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Er= ror **errp) > > sysbus_mmio_map(SYS_BUS_DEVICE(&s->qspi_dma), 0, QSPI_DMA_ADDR); > sysbus_connect_irq(SYS_BUS_DEVICE(&s->qspi_dma), 0, gic_spi[QSPI_IRQ= ]); > - object_property_set_link(OBJECT(&s->qspi), "stream-connected-dma", > - OBJECT(&s->qspi_dma), errp); > + > + if (!object_property_set_link(OBJECT(&s->qspi), "stream-connected-dm= a", > + OBJECT(&s->qspi_dma), errp)) { > + return; > + } > + if (!sysbus_realize(SYS_BUS_DEVICE(&s->qspi), errp)) { > + return; > + } > + sysbus_mmio_map(SYS_BUS_DEVICE(&s->qspi), 0, QSPI_ADDR); > + sysbus_mmio_map(SYS_BUS_DEVICE(&s->qspi), 1, LQSPI_ADDR); > + sysbus_connect_irq(SYS_BUS_DEVICE(&s->qspi), 0, gic_spi[QSPI_IRQ]); > + > + for (i =3D 0; i < XLNX_ZYNQMP_NUM_QSPI_BUS; i++) { > + g_autofree gchar *bus_name =3D g_strdup_printf("qspi%d", i); > + g_autofree gchar *target_bus =3D g_strdup_printf("spi%d", i); > + > + /* Alias controller SPI bus to the SoC itself */ > + object_property_add_alias(OBJECT(s), bus_name, > + OBJECT(&s->qspi), target_bus); > + } > } > > static Property xlnx_zynqmp_props[] =3D { > -- > 2.31.1 > >