From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF45D3E779 for ; Tue, 5 Nov 2024 22:30:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t8S3U-00057x-L0; Tue, 05 Nov 2024 17:29:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t8S3T-00057Q-2j; Tue, 05 Nov 2024 17:29:43 -0500 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t8S3R-0000ry-Ea; Tue, 05 Nov 2024 17:29:42 -0500 Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-84fdb038aaaso1803555241.3; Tue, 05 Nov 2024 14:29:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730845780; x=1731450580; darn=nongnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oGO9MICo6jKhq9VwPdZ6jahDb4TVdUEcMfxq2EiVi48=; b=EJn+ygVYvz/lEbbIG6A2ZAyL9wSao8dRuhdueyhOdY9+iInKkxn5GBX/+8AXSkM5kQ J02gu4HEOIzMOVjQde6IXwkIOd4P18lPcJVrbOeBAWjZtgoth1B/t7i12NADqLmqotz8 yrK/oF7UfXj8nMKi0zHIdh2IKZPi/fnQlFoZ+CQFHPdiS4dCd1yXwPaynxpHdlqx2r1i uGWzekc2vDWVEl0nIncjgfXOvScEiWkFwFSA8P0IXbxLcwbOAuLqX3yDmszrfW0tV4kg kLg1NjzhnhOwratkflbe4POqauw5hszK7Xt+mxkJRqLfl2q41iYG9kUYmC20HluNyExY 9yTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730845780; x=1731450580; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGO9MICo6jKhq9VwPdZ6jahDb4TVdUEcMfxq2EiVi48=; b=wVtm7lEI4wLayn5WK1PMkDclcCrvButIVjTzOl89DmJiiMr6JOYML10gND7GRfr5Mt gwgaYaztlGE3VAwEhc6ucScYSBw7dQPjVorMnWXmcAsPUR2rhgrHhu71E7lCuq+aTC05 5jysPG0TXnflwzE1mMKIR5kjQu/meBukR3oHpq20HMuWUfeOM2o6wiD8YsH+ywReZdUa Wn3B2UASneYJVbJ5TATtiuBh7Ty/LiXlPqbvM6eHxA7NS300JoL5otbpVqIJSoOei6SS ZZFRdmn8p0b7Y2ce5Qej3wgkTd1mpecyT65y+GPLdjdiGeTsjCCjjhDAawx+LYlKgS57 k0Cg== X-Forwarded-Encrypted: i=1; AJvYcCVjJ1F5CNa0xeu8/5OmtHwtkwIYEUBQIbUzJFFm8tc2+aF8opxVpaY8ZRczetM1sa/wgcrXuTF35g==@nongnu.org X-Gm-Message-State: AOJu0YzCmEIOudjJ++Hs/Nqm3FQv8JexUFDo5YYtd93xezC5KTYUhv5m kqzEhExqQHKNKAqMNCXndY+fqfOt+rBrkCrvlaKS0rhL4RkZ/UhX3H0yLfvbK2Vyqe5hwHR1fli SO0hw++j2Ru/t75SOTG8/0w0yUvM= X-Google-Smtp-Source: AGHT+IHOw40EByUcJARxPSwkiiHzsSnfI19m89X1t9JSsJXNuFT1CHBD7m2NzQIDi1aab3WV2YZNDfAmPYPA1/Z8nKo= X-Received: by 2002:a05:6102:370e:b0:498:ef8d:8368 with SMTP id ada2fe7eead31-4a962e0b82fmr15497448137.13.1730845779955; Tue, 05 Nov 2024 14:29:39 -0800 (PST) MIME-Version: 1.0 References: <20241105130431.22564-1-philmd@linaro.org> <20241105130431.22564-2-philmd@linaro.org> In-Reply-To: <20241105130431.22564-2-philmd@linaro.org> From: Alistair Francis Date: Wed, 6 Nov 2024 08:29:14 +1000 Message-ID: Subject: Re: [PATCH 01/19] target/microblaze: Rename CPU endianness property as 'little-endian' To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel@nongnu.org, Anton Johansson , "Edgar E. Iglesias" , Peter Maydell , Alistair Francis , Thomas Huth , qemu-arm@nongnu.org, devel@lists.libvirt.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Paolo Bonzini , Jason Wang , Richard Henderson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::930; envelope-from=alistair23@gmail.com; helo=mail-ua1-x930.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Nov 5, 2024 at 11:06=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 wrote: > > Rename the 'endian' property as 'little-endian' because the 'ENDI' > bit is set when the endianness is in little order, and unset in > big order. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/microblaze/petalogix_ml605_mmu.c | 2 +- > hw/microblaze/xlnx-zynqmp-pmu.c | 2 +- > target/microblaze/cpu.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogi= x_ml605_mmu.c > index b4183c5267d..df808ac323e 100644 > --- a/hw/microblaze/petalogix_ml605_mmu.c > +++ b/hw/microblaze/petalogix_ml605_mmu.c > @@ -90,7 +90,7 @@ petalogix_ml605_init(MachineState *machine) > object_property_set_int(OBJECT(cpu), "use-fpu", 1, &error_abort); > object_property_set_bool(OBJECT(cpu), "dcache-writeback", true, > &error_abort); > - object_property_set_bool(OBJECT(cpu), "endianness", true, &error_abo= rt); > + object_property_set_bool(OBJECT(cpu), "little-endian", true, &error_= abort); > qdev_realize(DEVICE(cpu), NULL, &error_abort); > > /* Attach emulated BRAM through the LMB. */ > diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-= pmu.c > index 1bfc9641d29..43608c2dca4 100644 > --- a/hw/microblaze/xlnx-zynqmp-pmu.c > +++ b/hw/microblaze/xlnx-zynqmp-pmu.c > @@ -90,7 +90,7 @@ static void xlnx_zynqmp_pmu_soc_realize(DeviceState *de= v, Error **errp) > object_property_set_bool(OBJECT(&s->cpu), "use-pcmp-instr", true, > &error_abort); > object_property_set_bool(OBJECT(&s->cpu), "use-mmu", false, &error_a= bort); > - object_property_set_bool(OBJECT(&s->cpu), "endianness", true, > + object_property_set_bool(OBJECT(&s->cpu), "little-endian", true, > &error_abort); > object_property_set_str(OBJECT(&s->cpu), "version", "8.40.b", > &error_abort); > diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c > index 135947ee800..e9f98806274 100644 > --- a/target/microblaze/cpu.c > +++ b/target/microblaze/cpu.c > @@ -368,7 +368,7 @@ static Property mb_properties[] =3D { > DEFINE_PROP_UINT8("use-non-secure", MicroBlazeCPU, cfg.use_non_secur= e, 0), > DEFINE_PROP_BOOL("dcache-writeback", MicroBlazeCPU, cfg.dcache_write= back, > false), > - DEFINE_PROP_BOOL("endianness", MicroBlazeCPU, cfg.endi, false), > + DEFINE_PROP_BOOL("little-endian", MicroBlazeCPU, cfg.endi, false), > /* Enables bus exceptions on failed data accesses (load/stores). */ > DEFINE_PROP_BOOL("dopb-bus-exception", MicroBlazeCPU, > cfg.dopb_bus_exception, false), > -- > 2.45.2 > >