From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C456FC06510 for ; Tue, 2 Jul 2019 17:55:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58B8F2082F for ; Tue, 2 Jul 2019 17:55:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXLmdoFd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58B8F2082F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiMzo-0006W5-Bl for qemu-devel@archiver.kernel.org; Tue, 02 Jul 2019 13:55:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44556) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiLI0-0003YL-8e for qemu-devel@nongnu.org; Tue, 02 Jul 2019 12:05:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiLHz-0001Mf-7x for qemu-devel@nongnu.org; Tue, 02 Jul 2019 12:05:52 -0400 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]:45105) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiLHy-0001Jm-RX; Tue, 02 Jul 2019 12:05:51 -0400 Received: by mail-lf1-x143.google.com with SMTP id u10so11756804lfm.12; Tue, 02 Jul 2019 09:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MelK9/24wgEDxir8AlFJoXVIGm/gACqxwd68SwN6Unw=; b=UXLmdoFdeFQOuGae+Klm8S09pNd/PGd3Fx4USmE8o8R1amXntyB7AFTo9h/9LZmMHJ IZ5GfynwjKI98kATLzMeYPoQLUvZKRYNAH0bmjvAfgCbVW/wZSWtZ1CMCh5ams5xaE3L yJuqa8Pzis8y8Kg5BdQaZvvQ8ILo7z30MFngQJWgJzMOKyhuLFOpa6j08K55SjO+TiuP jGH7m31cKOXkM/h2gRjgyfx40P0LpPRkJnCkGR8gdueeL7/lA6Kz0VGQ9cSyD3kiW42T J9Ux3BuILDg4FkmjujPsVwa+cAZneGx5ErfnvMB655x5ldctsIBI/4/KwYETDXqtWxEP Ybjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MelK9/24wgEDxir8AlFJoXVIGm/gACqxwd68SwN6Unw=; b=iH9/opyYHAXkgRAirk/3Zpx4n/PF6D+EOm1K3L+ck7nP+LzFTDFWw0fyjmIalSYwus VvSceeX/g6ZDcga7ZWXlL48hJywMS2mrfXpZWsltXeuhmZyoLFIzRhginjwX0FwCMxd0 ljg1JF4+uYc/uOxeFZwJCOSP2eCthNPAyWX7HpG7nYfKctXp4kMFyRrzduor5hmGKRyA tCukZdW+Y+nGImm/fHCqIYffnXnKvnVB+emrACUzzZPlIDpPMBP2Rmz+vqxWX/7rdgG4 zbWKxhKakniteSPWSSi7ubRcKS9ahZQ/27a5boGexa4e4/5GqDrCgEAph6nk6ZBZKn9C sB5A== X-Gm-Message-State: APjAAAWHIwGsTvHMOQGN7B6iGsNxWocP98waLpYumci5uAzMrxNGrXUd WhMmlP8LOL2cWIpSevjdQBnq7qD4nSMjO7W915M= X-Google-Smtp-Source: APXvYqxcD7/ledexO5fqoAvjpv9rCd/E8M+qmxQM0/puQbPP2Z2AS4fjg8Qw5NjaP33oBiWzu/p5trcJflQg9sINne8= X-Received: by 2002:a19:6a01:: with SMTP id u1mr211477lfu.141.1562083546622; Tue, 02 Jul 2019 09:05:46 -0700 (PDT) MIME-Version: 1.0 References: <20190702001301.4768-1-philmd@redhat.com> <20190702001301.4768-5-philmd@redhat.com> In-Reply-To: <20190702001301.4768-5-philmd@redhat.com> From: Alistair Francis Date: Tue, 2 Jul 2019 09:02:43 -0700 Message-ID: To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::143 Subject: Re: [Qemu-devel] [PATCH v2 4/9] hw/block/pflash_cfi01: Start state machine as READY to accept commands X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , "qemu-devel@nongnu.org Developers" , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Qemu-block , Aleksandar Rikalo , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Markus Armbruster , David Gibson , Eduardo Habkost , qemu-arm , John Snow , Richard Henderson , Kevin Wolf , Laszlo Ersek , Max Reitz , Michael Walle , "open list:New World" , Wei Yang , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 1, 2019 at 5:14 PM Philippe Mathieu-Daud=C3=A9 wrote: > > When the state machine is ready to accept command, the bit 7 of > the status register (SR) is set to 1. > The guest polls the status register and check this bit before > writting command to the internal 'Write State Machine' (WSM). > > Set SR.7 bit to 1 when the device is created. > > Reference: Read Array Flowchart > "Common Flash Interface (CFI) and Command Sets" > (Intel Application Note 646) > Appendix B "Basic Command Set" > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/block/pflash_cfi01.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c > index 33c77f6569..dd1dfd266b 100644 > --- a/hw/block/pflash_cfi01.c > +++ b/hw/block/pflash_cfi01.c > @@ -764,7 +764,7 @@ static void pflash_cfi01_realize(DeviceState *dev, Er= ror **errp) > } > > pflash_mode_read_array(pfl); > - pfl->status =3D 0; > + pfl->status =3D 0x80; /* WSM ready */ > /* Hardcoded CFI table */ > /* Standard "QRY" string */ > pfl->cfi_table[0x10] =3D 'Q'; > -- > 2.20.1 >