From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57468)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ZXvHt-0001Zf-O4
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 14:00:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ZXvHs-0006Nt-Ps
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 14:00:33 -0400
Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:32870)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1ZXvHs-0006NZ-LW
	for qemu-devel@nongnu.org; Fri, 04 Sep 2015 14:00:32 -0400
Received: by obbbh8 with SMTP id bh8so23042116obb.0
	for <qemu-devel@nongnu.org>; Fri, 04 Sep 2015 11:00:32 -0700 (PDT)
MIME-Version: 1.0
Sender: alistair23@gmail.com
In-Reply-To: <20150903225627.GB11697@toto>
References: <c795069e49040ff770fe2ece19dfe1791b729e22.1441316450.git.alistair.francis@xilinx.com>
	<20150903225627.GB11697@toto>
From: Alistair Francis <alistair.francis@xilinx.com>
Date: Fri, 4 Sep 2015 11:00:02 -0700
Message-ID: <CAKmqyKO2PSZDRNdfjKnEJ2DAf_ytdpsoi4B_iBx=R+eyAjQaKg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v1 1/1] cadence_gem: Correct Marvell PHY
 SPCFC reset value
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <crosthwaitepeter@gmail.com>, Edgar Iglesias <edgar.iglesias@gmail.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>

On Thu, Sep 3, 2015 at 3:56 PM, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
> On Thu, Sep 03, 2015 at 03:10:52PM -0700, Alistair Francis wrote:
>> Bit 15 of the PHY Specific Status Register is reserved and
>> should remain 0. Fix the reset value to ensure that the 15th
>> bit is not set.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Thanks Edgar.

Should this go via the ARM queue?

Thanks,

Alistair

>
>
>> ---
>> http://www.marvell.com/transceivers/assets/Marvell-88E3016-Fast-Ethernet.pdf
>>
>>  hw/net/cadence_gem.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
>> index 494a346..1127223 100644
>> --- a/hw/net/cadence_gem.c
>> +++ b/hw/net/cadence_gem.c
>> @@ -951,7 +951,7 @@ static void gem_phy_reset(CadenceGEMState *s)
>>      s->phy_regs[PHY_REG_1000BTSTAT] = 0x7C00;
>>      s->phy_regs[PHY_REG_EXTSTAT] = 0x3000;
>>      s->phy_regs[PHY_REG_PHYSPCFC_CTL] = 0x0078;
>> -    s->phy_regs[PHY_REG_PHYSPCFC_ST] = 0xBC00;
>> +    s->phy_regs[PHY_REG_PHYSPCFC_ST] = 0x7C00;
>>      s->phy_regs[PHY_REG_EXT_PHYSPCFC_CTL] = 0x0C60;
>>      s->phy_regs[PHY_REG_LED] = 0x4100;
>>      s->phy_regs[PHY_REG_EXT_PHYSPCFC_CTL2] = 0x000A;
>> --
>> 1.7.1
>>
>