From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F10BDC433E0 for ; Fri, 15 Jan 2021 01:24:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E73322CBE for ; Fri, 15 Jan 2021 01:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E73322CBE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0DqS-000439-Ih for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 20:24:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0Dnw-0003Nb-Q6 for qemu-devel@nongnu.org; Thu, 14 Jan 2021 20:21:33 -0500 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]:46134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0Dnq-0008Km-MU for qemu-devel@nongnu.org; Thu, 14 Jan 2021 20:21:31 -0500 Received: by mail-io1-xd2f.google.com with SMTP id q2so13531564iow.13 for ; Thu, 14 Jan 2021 17:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ehN0aVDLHZMI0mbOibsH1VJJIgb7jT0JtgVEhwMqP2I=; b=ATEKHQJjh13ynJSVyXl4NegOFqm/qtLUWHC7Op8DdjOG24/qA71RfgZe/8zWwP8eO3 i8fSSjbGcrHGEUrM7CbN0NShSxD61WhPvF1ORqtwpOjvsiG4e2w6DBpZsFazVYIP9wT2 mOt69dmZ906+Jop5DLVXjAfRgTe0g8AMb4zkIATZXQkrDcV5LH8J7dnI+5pLYKNWDnxv HvV92lzQ5eXxRa+6nU6GvrhEBsd+dKKW0Hwf9fnH3Dy/pehoJ7k1XUXnv+nNIRsW4AfT fgT5oj0EVv8602IE8jFQaYkJTvWIVrGZ7V009oHs8VgvO7CoWF5A+5V1HtsOYVn2KtKS lePg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehN0aVDLHZMI0mbOibsH1VJJIgb7jT0JtgVEhwMqP2I=; b=qNY9T6yPN3BYATIZ6s2+98ugybn9ljsPWEvcC1EctG9WqHqxkCdTtLBUeYQ4r2hB+v BidSX3pS0pCDTzdgtJHkX0TWwk1LiKlxc0NsmU8z6lQPFkmW8HBFG486l/q+XQHLkl/Q /Oh/O5Q/5PkJePl20FeDYidFFc1wGfOZ/FdNKKNEVfILsgOySd9L8PvJSLuBVpMjhwzH umcvpwk221Bs4oWRG2WT0dmYh/5+/1iktUYdkeQaF8eriQxaDOUuf1JrZn2Ukipqd7nh PlEpq/jqgN4ZfjnvVIp3g+Osvtpb7BxCuHC02g3Btm8h4pCf4KS+PrwcLxLpfjBDOPYE Uh5A== X-Gm-Message-State: AOAM531n6msLLZiqanNXXZEogJcVI3ahWqeNNnTYKqZp0VPsSdrJAN/e niworS/Op3goWRRN/1ZOKOAU3TkCqeAK8+y2jeY= X-Google-Smtp-Source: ABdhPJwjgk3iAaECq7RCGfBgRpHeoLIHKCB/ULOiEHTIFBRyYGDzHt+KZBl2bdpBboAV+K6/iiobgSft6ouMROIhS38= X-Received: by 2002:a92:cda1:: with SMTP id g1mr9063636ild.267.1610673682020; Thu, 14 Jan 2021 17:21:22 -0800 (PST) MIME-Version: 1.0 References: <20201218060114.3591217-1-alistair.francis@wdc.com> <20201218060114.3591217-23-alistair.francis@wdc.com> In-Reply-To: From: Alistair Francis Date: Thu, 14 Jan 2021 17:20:55 -0800 Message-ID: Subject: Re: [PULL 22/23] hw/riscv: Use the CPU to determine if 32-bit To: Peter Maydell Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2f; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Alistair Francis , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Jan 10, 2021 at 11:55 AM Peter Maydell wrote: > > On Fri, 18 Dec 2020 at 06:01, Alistair Francis wrote: > > > > Instead of using string compares to determine if a RISC-V machine is > > using 32-bit or 64-bit CPUs we can use the initalised CPUs. This avoids > > us having to maintain a list of CPU names to compare against. > > > > This commit also fixes the name of the function to match the > > riscv_cpu_is_32bit() function. > > > > Signed-off-by: Alistair Francis > > Reviewed-by: Richard Henderson > > Message-id: 8ab7614e5df93ab5267788b73dcd75f9f5615e82.1608142916.git.alistair.francis@wdc.com > > Hi; coverity points out a probably-unintentional inefficiency here > (CID 1438099, CID 1438100, CID 1438101): > > > --- a/hw/riscv/boot.c > > +++ b/hw/riscv/boot.c > > @@ -33,28 +33,16 @@ > > > > #include > > > > -bool riscv_is_32_bit(MachineState *machine) > > +bool riscv_is_32bit(RISCVHartArrayState harts) > > The RISCVHartArrayState type is 824 bytes long. That's a very > big type to be passing by value. You probably wanted to pass a > pointer to it instead. Similarly for the arguments to > riscv_calc_kernel_start_addr() and riscv_setup_rom_reset_vec(). Thanks Peter, I'll send a patch. Alistair > > thanks > -- PMM