From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS4wq-0007JV-LS for qemu-devel@nongnu.org; Tue, 26 Jul 2016 12:11:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS4wo-0000Sx-LN for qemu-devel@nongnu.org; Tue, 26 Jul 2016 12:11:11 -0400 MIME-Version: 1.0 Sender: alistair23@gmail.com In-Reply-To: References: <5778bd2c8a0fe59682bf830c2c17ff7207b296d7.1469491920.git.alistair.francis@xilinx.com> From: Alistair Francis Date: Tue, 26 Jul 2016 09:10:33 -0700 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 2/6] cadence_gem: Add the num-priority-queues property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alistair Francis , Peter Crosthwaite , qemu-arm , QEMU Developers On Tue, Jul 26, 2016 at 4:47 AM, Peter Maydell wrote: > On 26 July 2016 at 01:12, Alistair Francis wrote: >> The Cadence GEM hardware supports N number priority queues, this patch is a >> step towards that by adding the property to set the queues. At the moment >> behaviour doesn't change as we only use queue 0. >> >> Signed-off-by: Alistair Francis >> --- > >> @@ -1218,7 +1220,7 @@ static void gem_realize(DeviceState *dev, Error **errp) >> { >> CadenceGEMState *s = CADENCE_GEM(dev); >> >> - sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq); >> + sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq[0]); >> >> qemu_macaddr_default_if_unset(&s->conf.macaddr); > > At some point realize() needs to error-check the num-priority-queues > property (ie check it isn't >8). Do you do that later in the series? > (if so fine, if not, this patch is as good a place as any to put it.) I'll add it in here. > >> @@ -1243,13 +1245,15 @@ static void gem_init(Object *obj) >> static const VMStateDescription vmstate_cadence_gem = { >> .name = "cadence_gem", >> .version_id = 2, >> - .minimum_version_id = 2, >> + .minimum_version_id = 3, > > You need to bump .version_id too. Yep, I misread it and thought it was a a.b version format. I'll fix up the other one as well. > > Otherwise > Reviewed-by: Peter Maydell Thanks! Alistair > > thanks > -- PMM >