qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: maozhongyi@cmss.chinamobile.com
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	qemu-riscv@nongnu.org,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize
Date: Mon, 26 Nov 2018 08:04:26 -0800	[thread overview]
Message-ID: <CAKmqyKOMsHi4wr4xDkhSxEou1k9hxvgUtu_94bBQ35fgKAvvKw@mail.gmail.com> (raw)
In-Reply-To: <20181126032038.22044-1-maozhongyi@cmss.chinamobile.com>

On Sun, Nov 25, 2018 at 7:21 PM Mao Zhongyi
<maozhongyi@cmss.chinamobile.com> wrote:
>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/cpu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index a025a0a3ba..5e8a2cb2ba 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -330,8 +330,8 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>      CPUClass *cc = CPU_CLASS(c);
>      DeviceClass *dc = DEVICE_CLASS(c);
>
> -    mcc->parent_realize = dc->realize;
> -    dc->realize = riscv_cpu_realize;
> +    device_class_set_parent_realize(dc, riscv_cpu_realize,
> +                                    &mcc->parent_realize);
>
>      mcc->parent_reset = cc->reset;
>      cc->reset = riscv_cpu_reset;
> --
> 2.17.1
>
>
>
>

      parent reply	other threads:[~2018-11-26 16:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26  3:20 [Qemu-devel] [PATCH] riscv/cpu: use device_class_set_parent_realize Mao Zhongyi
2018-11-26  9:06 ` Bastian Koppelmann
2018-11-28  0:34   ` Palmer Dabbelt
2018-11-28  1:46     ` maozy
2018-11-28 18:51       ` Palmer Dabbelt
2018-11-26 16:04 ` Alistair Francis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKOMsHi4wr4xDkhSxEou1k9hxvgUtu_94bBQ35fgKAvvKw@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=maozhongyi@cmss.chinamobile.com \
    --cc=mjc@sifive.com \
    --cc=palmer@sifive.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).