From: Alistair Francis <alistair23@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Konstanty Bialkowski <konstanty@ieee.org>
Subject: Re: [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2 USART Controller
Date: Tue, 2 Sep 2014 12:04:34 +1000 [thread overview]
Message-ID: <CAKmqyKOWVCU7ZxK6idBaDmXic3016KVggz0NHBLB+PbUpFVQHQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9hexD8KpEqwZLJqShwapHrntpihuDYPUn_LfU6TCucpA@mail.gmail.com>
On Tue, Sep 2, 2014 at 2:30 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 24 August 2014 03:09, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
>> If you make your registers an array, you can index the with the offset
>> and remove the repeated s->foo return logic. You can also use a single
>> memset to do all the 0 resets.
>
> Hmm. I dislike that style personally, especially for devices
> like this which only have a handful of registers.
I think it'll end up being just as complex, as some of the offsets
cause multiple registers to change (status registers and things
like that)
I'll keep it as a switch case for now
Thanks,
Alistair
>
> -- PMM
next prev parent reply other threads:[~2014-09-02 2:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 0:13 [Qemu-devel] [PATCH v1 0/5] Netduino Plus 2 Machine Model Alistair Francis
2014-08-24 0:13 ` [Qemu-devel] [PATCH v1 1/5] Netduino_USART: Add the Netduino Plus 2 USART Controller Alistair Francis
2014-08-24 2:09 ` Peter Crosthwaite
2014-08-26 14:19 ` Alistair Francis
2014-09-01 16:30 ` Peter Maydell
2014-09-02 2:04 ` Alistair Francis [this message]
2014-08-24 0:13 ` [Qemu-devel] [PATCH v1 2/5] Netduino_GPIO: Add the Netduino Plus 2 GPIO controller Alistair Francis
2014-09-01 16:29 ` Peter Maydell
2014-09-02 2:37 ` Alistair Francis
2014-08-24 0:14 ` [Qemu-devel] [PATCH v1 3/5] Netduino_SYSCFG: Add the Netduino Plus 2 SYSCFG Alistair Francis
2014-08-24 3:09 ` Peter Crosthwaite
2014-09-01 11:49 ` Alistair Francis
2014-08-24 0:14 ` [Qemu-devel] [PATCH v1 4/5] Netduino_Timer: Add the Netduino Plus 2 Timer2 to 5 Alistair Francis
2014-08-24 3:27 ` Peter Crosthwaite
2014-08-24 0:14 ` [Qemu-devel] [PATCH v1 5/5] Netduino: Add the Netduino Plus 2 Machine Model Alistair Francis
2014-08-24 13:20 ` Peter Crosthwaite
2014-09-01 12:34 ` Alistair Francis
2014-09-01 12:44 ` Peter Maydell
2014-09-01 16:33 ` Peter Maydell
2014-09-02 2:02 ` Alistair Francis
2014-09-01 16:39 ` [Qemu-devel] [PATCH v1 0/5] " Peter Maydell
2014-09-02 1:55 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKOWVCU7ZxK6idBaDmXic3016KVggz0NHBLB+PbUpFVQHQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=konstanty@ieee.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).