From: Alistair Francis <alistair23@gmail.com>
To: "KONRAD Frédéric" <fred.konrad@greensocs.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
hyunk@xilinx.com, Mark Burton <mark.burton@greensocs.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Guillaume Delbergue <guillaume.delbergue@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field.
Date: Tue, 1 Sep 2015 15:52:20 -0700 [thread overview]
Message-ID: <CAKmqyKOYbA+dzuarYKBxCyQ77VnNvjWikQCLfPDTG-oSZkpkaw@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKOQYMMHEcm=yOmMKjy-7gSSDhuQHEnBFu8YXdK+2dKyGg@mail.gmail.com>
On Tue, Sep 1, 2015 at 1:58 PM, Alistair Francis <alistair23@gmail.com> wrote:
> On Tue, Jul 21, 2015 at 10:17 AM, <fred.konrad@greensocs.com> wrote:
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>
>> Seems this field is not needed.
>
> The commit message should be updated to represent the patch.
>
>>
>> Signed-off-by: KONRAD Frederic <fred.konrad@greensocs.com>
>
> Otherwise:
>
> Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Just so these don't get forgotten:
Tested-By: Hyun Kwon <hyun.kwon@xilinx.com>
Thanks,
Alistair
>
> Thanks,
>
> Alistair
>
>> ---
>> hw/i2c/core.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/i2c/core.c b/hw/i2c/core.c
>> index 5a64026..e0f92de 100644
>> --- a/hw/i2c/core.c
>> +++ b/hw/i2c/core.c
>> @@ -13,7 +13,6 @@ struct I2CBus
>> {
>> BusState qbus;
>> I2CSlave *current_dev;
>> - I2CSlave *dev;
>> uint8_t saved_address;
>> };
>>
>> --
>> 1.9.0
>>
>>
next prev parent reply other threads:[~2015-09-01 22:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 17:17 [Qemu-devel] [PATCH V4 0/8] Xilinx DisplayPort fred.konrad
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 1/8] i2cbus: remove unused dev field fred.konrad
2015-09-01 20:58 ` Alistair Francis
2015-09-01 22:52 ` Alistair Francis [this message]
2015-09-04 22:50 ` Frederic Konrad
2015-09-04 23:43 ` Alistair Francis
2015-09-05 19:44 ` Peter Crosthwaite
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 2/8] Introduce AUX bus fred.konrad
2015-09-01 21:48 ` Alistair Francis
2015-09-02 0:00 ` Alistair Francis
2015-09-04 22:51 ` Frederic Konrad
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 3/8] i2c: implement broadcast write fred.konrad
2015-09-01 22:53 ` Alistair Francis
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 4/8] introduce dpcd module fred.konrad
2015-09-01 23:19 ` Alistair Francis
2015-09-04 22:54 ` Frederic Konrad
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 5/8] hw/i2c-ddc.c: Implement DDC I2C slave fred.konrad
2015-09-01 23:55 ` Alistair Francis
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 6/8] Introduce xilinx dpdma fred.konrad
2015-09-02 21:39 ` Alistair Francis
2015-09-03 7:28 ` Frederic Konrad
2015-09-03 23:34 ` Alistair Francis
2015-09-04 9:01 ` Frederic Konrad
2015-09-04 18:21 ` Alistair Francis
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 7/8] Introduce xilinx dp fred.konrad
2015-07-21 17:17 ` [Qemu-devel] [PATCH V4 8/8] arm: xlnx-zynqmp: Add DisplayPort and DPDMA fred.konrad
2015-09-01 17:24 ` [Qemu-devel] [PATCH V4 0/8] Xilinx DisplayPort Peter Maydell
2015-09-01 21:08 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKOYbA+dzuarYKBxCyQ77VnNvjWikQCLfPDTG-oSZkpkaw@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=fred.konrad@greensocs.com \
--cc=guillaume.delbergue@greensocs.com \
--cc=hyunk@xilinx.com \
--cc=mark.burton@greensocs.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).