From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 397A7C433E0 for ; Fri, 12 Feb 2021 22:14:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C361E64E0A for ; Fri, 12 Feb 2021 22:14:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C361E64E0A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAghN-0001Lq-NA for qemu-devel@archiver.kernel.org; Fri, 12 Feb 2021 17:14:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAgce-00070F-D0; Fri, 12 Feb 2021 17:09:08 -0500 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]:46138) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAgcc-0000xL-LD; Fri, 12 Feb 2021 17:09:08 -0500 Received: by mail-io1-xd2b.google.com with SMTP id u8so702219ior.13; Fri, 12 Feb 2021 14:09:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BVyBH/CwJNMTMooaiCv6r+r9iTHgOAa/UjqD1FaGRU8=; b=BY6UksFJjo1sWqxF5jxiY1YKsFTop+6cSJQ3APKq0XMOYAsO43Oy95Z/y5+DAkMXqd FUDDh7iPhhUwt8s7Smv6/LkYpmd43FNqIGvt146UeLYJjpch075+p689KS3COGVhG4Re uSeOSEiz4HFNQDsBFrK8/XTg4a/AExndy2NzdxPcfyYMr/lP4dLX722EqNOqRd0gqF3v CmaWK/NE9za4HAjap0g5dewdqoNeV8O2UEy721Of0sjze0U+6NiJD0/n1BubjNkes/+j NHPjGBTAqtx1bIe7m8D9q0nUvTIqyR6hMFQlL7klgkje2efW63Xe5Vf4X8R48njFgcNO Szxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BVyBH/CwJNMTMooaiCv6r+r9iTHgOAa/UjqD1FaGRU8=; b=A6giY9O3TetJNsY5ItQm14YOTUFYd9n8bYhqx++MJjVwMdZ4dnkVnBE15ZGAkRwEX0 YdLyeN+U243GmC/3L0dw1ESX0hiz3fs7BkhceSb9C1HHRhn+ncsQaFSGlKlIl89AfHbu DlSdFj12qF5FwlW/jdbSxt5UbZ5lFmtjHj1dOXTKKJhkjNbCH3O6y5WKpuYmJIuY9Hmp sT3BVShS+cJJ6sYsnBH3gZ6PhLQVHxdIlYJkwNhR1bjhNbdbP8fzGG+9BqqOZj7WEYfD oBuUgRWptIq7WTzmWmzaS+7bb70ulvIkwWcQCip9TZzyl7ySVX6Z1fFpONK0CmQnOi/R Xd5A== X-Gm-Message-State: AOAM533nGZElwshZlFRCMsxN81c2AWTBbcyRKGDgs60HNamr4udiTQIJ 4zNaYLGPZLZT2YcnNOPCCc0nuhiRWI8x5Jc58ho= X-Google-Smtp-Source: ABdhPJywYidSR7O/9a2ogQBlj4em3rIJK6WOdKX9+z8+rmNh/84kWBtRmnWCWA0Gyt4Zi67LVHuYqmL0PqxcWndXK4Q= X-Received: by 2002:a5d:854b:: with SMTP id b11mr3700676ios.105.1613167745358; Fri, 12 Feb 2021 14:09:05 -0800 (PST) MIME-Version: 1.0 References: <1613031446-22154-1-git-send-email-sai.pavan.boddu@xilinx.com> <1613031446-22154-10-git-send-email-sai.pavan.boddu@xilinx.com> In-Reply-To: <1613031446-22154-10-git-send-email-sai.pavan.boddu@xilinx.com> From: Alistair Francis Date: Fri, 12 Feb 2021 14:08:24 -0800 Message-ID: Subject: Re: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase To: Sai Pavan Boddu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2b; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , Vladimir Sementsov-Ogievskiy , Vincent Palatin , "Edgar E. Iglesias" , Qemu-block , "qemu-devel@nongnu.org Developers" , Markus Armbruster , Max Reitz , Sai Pavan Boddu , Luc Michel , Alistair Francis , Joel Stanley , Stefan Hajnoczi , Paolo Bonzini , "Dr. David Alan Gilbert" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 11, 2021 at 12:19 AM Sai Pavan Boddu wrote: > > Add CMD35 and CMD36 which sets the erase start and end. > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Edgar E. Iglesias > --- > hw/sd/sd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index 236f2b8..7aab647 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -1544,6 +1544,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) > > /* Erase commands (Class 5) */ > case 32: /* CMD32: ERASE_WR_BLK_START */ > + case 35: Can you comment the CMD here? > switch (sd->state) { > case sd_transfer_state: > sd->erase_start = req.arg; > @@ -1555,6 +1556,7 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) > break; > > case 33: /* CMD33: ERASE_WR_BLK_END */ > + case 36: and here? Alistair > switch (sd->state) { > case sd_transfer_state: > sd->erase_end = req.arg; > -- > 2.7.4 > >