Re: [PATCH v2 0/9] hw/riscv/virt.c: memmap usage cleanup

[Alistair Francis <alistair23@gmail.com>]

On Tue, Apr 29, 2025 at 11:00 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Hi,
>
> In this new version a small change was made in patch 9 after
> discussions with Joel during v1 [1]. The idea is that we want to be
> consistent (as close as we can) with the idea that a
> memory address is a hwaddr type.
>
> This new version does not conflict with "hw/riscv/virt: device tree reg
> cleanups" from Joel [2].
>
> No other changes made. Patches based on alistair/riscv-to-apply.next.
>
> Changes from v2:
> - patch 9:
>   - in create_fdt_socket_memory(), change 'addr' to hwaddr and use the
>     HWADDR_PRIx fmt type
> - v1 link: https://lore.kernel.org/qemu-riscv/20250423110630.2249904-1-dbarboza@ventanamicro.com/
>
> [1] https://lore.kernel.org/qemu-riscv/d404d535-fc04-43ac-a7a7-2f216cad993c@ventanamicro.com/
> [2] https://lore.kernel.org/qemu-riscv/20250429061223.1457166-1-joel@jms.id.au/
>
> Daniel Henrique Barboza (9):
>   hw/riscv/virt.c: enforce s->memmap use in machine_init()
>   hw/riscv/virt.c: remove trivial virt_memmap references
>   hw/riscv/virt.c: use s->memmap in virt_machine_done()
>   hw/riscv/virt.c: add 'base' arg in create_fw_cfg()
>   hw/riscv/virt.c: use s->memmap in create_fdt() path
>   hw/riscv/virt.c: use s->memmap in create_fdt_sockets() path
>   hw/riscv/virt.c: use s->memmap in create_fdt_virtio()
>   hw/riscv/virt.c: use s->memmap in finalize_fdt() functions
>   hw/riscv/virt.c: remove 'long' casts in fmt strings

Thanks!

Applied to riscv-to-apply.next

Alistair

>
>  hw/riscv/virt.c | 272 +++++++++++++++++++++++++-----------------------
>  1 file changed, 140 insertions(+), 132 deletions(-)
>
> --
> 2.49.0
>
>