qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: philmd@redhat.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Edgar Iglesias <edgar.iglesias@gmail.com>,
	Igor Mitsyanko <i.mitsyanko@gmail.com>,
	Alistair Francis <alistair@alistair23.me>,
	qemu-arm <qemu-arm@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro
Date: Mon, 29 Oct 2018 16:47:44 -0700	[thread overview]
Message-ID: <CAKmqyKOnfcm6_AYWmZn+SdHtdY6Fr0s7xLVn-XPGm=ayk7imNw@mail.gmail.com> (raw)
In-Reply-To: <20181029232100.8454-2-philmd@redhat.com>

On Mon, Oct 29, 2018 at 4:22 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  hw/arm/xilinx_zynq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index f1496d2927..57497b0c4d 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -294,7 +294,7 @@ static void zynq_init(MachineState *machine)
>      busdev = SYS_BUS_DEVICE(dev);
>      sysbus_mmio_map(busdev, 0, 0xF8003000);
>      sysbus_connect_irq(busdev, 0, pic[45-IRQ_OFFSET]); /* abort irq line */
> -    for (n = 0; n < 8; ++n) { /* event irqs */
> +    for (n = 0; n < ARRAY_SIZE(dma_irqs); ++n) { /* event irqs */
>          sysbus_connect_irq(busdev, n + 1, pic[dma_irqs[n] - IRQ_OFFSET]);
>      }
>
> --
> 2.17.2
>
>

  reply	other threads:[~2018-10-29 23:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-29 23:20 [Qemu-devel] [PATCH 0/3] hw/arm/exynos4: Add DMA support for SMDKC210 board Philippe Mathieu-Daudé
2018-10-29 23:20 ` [Qemu-devel] [PATCH 1/3] hw/arm/xilinx_zynq: Use the ARRAY_SIZE macro Philippe Mathieu-Daudé
2018-10-29 23:47   ` Alistair Francis [this message]
2018-10-30  8:16   ` Richard Henderson
2018-10-29 23:20 ` [Qemu-devel] [PATCH 2/3] hw/dma/pl330: Factor out pl330_init() from hw/arm/xilinx_zynq.c Philippe Mathieu-Daudé
2018-10-29 23:49   ` Alistair Francis
2018-10-30  8:18   ` Richard Henderson
2018-10-30  8:35     ` Philippe Mathieu-Daudé
2018-10-30  9:36   ` Peter Maydell
2018-10-30 11:28     ` Philippe Mathieu-Daudé
2018-10-30 12:42       ` Peter Maydell
2018-10-30 13:01         ` Philippe Mathieu-Daudé
2018-10-30 11:26   ` Philippe Mathieu-Daudé
2018-10-29 23:21 ` [Qemu-devel] [PATCH 3/3] arm: exynos4: Add dma support for smdkc210 Philippe Mathieu-Daudé
2018-10-29 23:47   ` Alistair Francis
2018-10-31  4:06 ` [Qemu-devel] [PATCH 0/3] hw/arm/exynos4: Add DMA support for SMDKC210 board no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKOnfcm6_AYWmZn+SdHtdY6Fr0s7xLVn-XPGm=ayk7imNw@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=edgar.iglesias@gmail.com \
    --cc=i.mitsyanko@gmail.com \
    --cc=linux@roeck-us.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).