From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0589FC636CC for ; Thu, 9 Feb 2023 00:22:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPuhB-0002r1-60; Wed, 08 Feb 2023 19:21:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPuh9-0002q8-4e; Wed, 08 Feb 2023 19:21:47 -0500 Received: from mail-vk1-xa2f.google.com ([2607:f8b0:4864:20::a2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPuh7-0004qT-8g; Wed, 08 Feb 2023 19:21:46 -0500 Received: by mail-vk1-xa2f.google.com with SMTP id n13so125364vkl.8; Wed, 08 Feb 2023 16:21:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=N2iVpHhFeE7trcpuPb4MC/oo6zMdINLLmqqfElixnZs=; b=kWcjXc5yUGLoMqs4Weu1N7rfX4l3Ea203ouvEUyQqaTo+OyNFJJUKIMNQCRWTibcIl KXTE/CBbsKU6YWmLBBvYscvsMu6iURw24ZBczZmzXHs1BZiIaNVwox6K/DmXU8iDh6qq dAtrrGsFgRp7TquBz0eCcWl72NV7MdSM6PiIV6aOleuSdMpOXgf4Cq4GtRjqKP5QT4Ot 9PccS5Q+Kw2tNgDWGyBIfKTNfT09Kf7iB2KFIpyfOL7bNHNFlRT5VsmGpW+dPqQhv0QS FNDUhv8937nuCYn12hgNPWsE79HspzhK4wwpBgKeSm2B2+/4VKYseUDYUn5ysONuEhJt qdtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N2iVpHhFeE7trcpuPb4MC/oo6zMdINLLmqqfElixnZs=; b=wjECaGLTED3LxTcchwNTwm41hoOlwbH2QMvxcpcJsHQxqxSf7FJPxal4cpUCqgpTcc Q2xLOL6I1b51XgAYJjOnC64XKdVMO5evPYyi35QpiBUdb1+NQq/GSxZickuKNqT9B752 mMFqxw01uqmLuBA5R1K5tKmZ3Vl1aUPRTC3QkNLa36Fw9ByYNcsEhd1cfRoI22kS8OlX 0kAWuaIiTxRdsS4EW+DTbZsex/8zcl8Z9Oz6JyriNcXW41UfWOe90jn49r22RrPZrxJa 0qKtutfpAAksMQt2uRadyDrKLdulXNjZaJMdXryxhiwI7NnkDo/H1xfBX3AAIy+MXHud fspw== X-Gm-Message-State: AO0yUKVXozAPe/LWrViBa8pxxza1Mn5TyZI8ohVQ/8OgZsggErpOjxHg YAq57WybbPbnlVpWIyp5xHCsqU0B+cNqR/FGec0= X-Google-Smtp-Source: AK7set9zXvWnc8o8i2YZCsEgTUY8/2hffLXd1I1LBTFeLPyNhG63hpbhCArqc/vaIHD8RbiKiS0VDIQZrm/WDLK41gk= X-Received: by 2002:a1f:2414:0:b0:3ea:3dee:4545 with SMTP id k20-20020a1f2414000000b003ea3dee4545mr2012447vkk.26.1675902103580; Wed, 08 Feb 2023 16:21:43 -0800 (PST) MIME-Version: 1.0 References: <20230202045223.2594627-1-sunilvl@ventanamicro.com> <20230202045223.2594627-6-sunilvl@ventanamicro.com> In-Reply-To: <20230202045223.2594627-6-sunilvl@ventanamicro.com> From: Alistair Francis Date: Thu, 9 Feb 2023 10:21:17 +1000 Message-ID: Subject: Re: [PATCH 05/10] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT To: Sunil V L Cc: Palmer Dabbelt , Alistair Francis , Bin Meng , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Andrew Jones , Anup Patel , Atish Kumar Patra Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::a2f; envelope-from=alistair23@gmail.com; helo=mail-vk1-xa2f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Feb 2, 2023 at 2:54 PM Sunil V L wrote: > > Add Multiple APIC Description Table (MADT) with the > INTC structure for each cpu. > > Signed-off-by: Sunil V L Acked-by: Alistair Francis Alistair > --- > hw/riscv/virt-acpi-build.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/hw/riscv/virt-acpi-build.c b/hw/riscv/virt-acpi-build.c > index 0410b955bd..2f65f1e2e5 100644 > --- a/hw/riscv/virt-acpi-build.c > +++ b/hw/riscv/virt-acpi-build.c > @@ -137,6 +137,43 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, RISCVVirtState *vms) > free_aml_allocator(); > } > > +/* MADT */ > +static void > +build_madt(GArray *table_data, BIOSLinker *linker, RISCVVirtState *vms) > +{ > + MachineState *mc = MACHINE(vms); > + int socket; > + uint16_t base_hartid = 0; > + uint32_t cpu_id = 0; > + > + AcpiTable table = { .sig = "APIC", .rev = 6, .oem_id = vms->oem_id, > + .oem_table_id = vms->oem_table_id }; > + > + acpi_table_begin(&table, table_data); > + /* Local Interrupt Controller Address */ > + build_append_int_noprefix(table_data, 0, 4); > + build_append_int_noprefix(table_data, 0, 4); /* MADT Flags */ > + > + /* RISC-V Local INTC structures per HART */ > + for (socket = 0; socket < riscv_socket_count(mc); socket++) { > + base_hartid = riscv_socket_first_hartid(mc, socket); > + > + for (int i = 0; i < vms->soc[socket].num_harts; i++) { > + build_append_int_noprefix(table_data, 0x18, 1); /* Type */ > + build_append_int_noprefix(table_data, 20, 1); /* Length */ > + build_append_int_noprefix(table_data, 1, 1); /* Version */ > + build_append_int_noprefix(table_data, 0, 1); /* Reserved */ > + build_append_int_noprefix(table_data, 1, 4); /* Flags */ > + build_append_int_noprefix(table_data, > + (base_hartid + i), 8); /* hartid */ > + build_append_int_noprefix(table_data, cpu_id, 4); /* ACPI ID */ > + cpu_id++; > + } > + } > + > + acpi_table_end(linker, &table); > +} > + > static void > virt_acpi_build(RISCVVirtState *vms, AcpiBuildTables *tables) > { > -- > 2.38.0 > >