From: Alistair Francis <alistair23@gmail.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com, ajones@ventanamicro.com
Subject: Re: [PATCH 1/3] target/riscv/kvm: change kvm_reg_id to uint64_t
Date: Thu, 25 Jan 2024 13:20:12 +1000 [thread overview]
Message-ID: <CAKmqyKP7-+qcr451XZE==W4PYmBMqTphk2sGNaC8V-pTkEuOzg@mail.gmail.com> (raw)
In-Reply-To: <20240123161714.160149-2-dbarboza@ventanamicro.com>
On Wed, Jan 24, 2024 at 2:18 AM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> The field isn't big enough to hold an uint64_t kvm register and Vector
> registers will end up overflowing it.
>
> Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/kvm/kvm-cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c
> index 4dec91740b..902180e8a5 100644
> --- a/target/riscv/kvm/kvm-cpu.c
> +++ b/target/riscv/kvm/kvm-cpu.c
> @@ -145,7 +145,7 @@ typedef struct KVMCPUConfig {
> const char *name;
> const char *description;
> target_ulong offset;
> - int kvm_reg_id;
> + uint64_t kvm_reg_id;
> bool user_set;
> bool supported;
> } KVMCPUConfig;
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2024-01-25 3:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 16:17 [PATCH 0/3] target/riscv/kvm: support 'vlenb' and vregs[] Daniel Henrique Barboza
2024-01-23 16:17 ` [PATCH 1/3] target/riscv/kvm: change kvm_reg_id to uint64_t Daniel Henrique Barboza
2024-01-25 3:20 ` Alistair Francis [this message]
2024-01-23 16:17 ` [PATCH 2/3] target/riscv/kvm: initialize 'vlenb' via get-reg-list Daniel Henrique Barboza
2024-01-25 3:23 ` Alistair Francis
2024-01-23 16:17 ` [PATCH 3/3] target/riscv/kvm: get/set vector vregs[] Daniel Henrique Barboza
2024-01-25 3:28 ` Alistair Francis
2024-01-25 4:48 ` [PATCH 0/3] target/riscv/kvm: support 'vlenb' and vregs[] Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKP7-+qcr451XZE==W4PYmBMqTphk2sGNaC8V-pTkEuOzg@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liwei1518@gmail.com \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).