From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drv2L-0006o7-0h for qemu-devel@nongnu.org; Tue, 12 Sep 2017 19:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drv2K-0000qT-44 for qemu-devel@nongnu.org; Tue, 12 Sep 2017 19:56:13 -0400 MIME-Version: 1.0 In-Reply-To: <1505232834-20890-1-git-send-email-peter.maydell@linaro.org> References: <1505232834-20890-1-git-send-email-peter.maydell@linaro.org> From: Alistair Francis Date: Tue, 12 Sep 2017 16:55:40 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [Qemu-devel] [PATCH] mps2-an511: Fix wiring of UART overflow interrupt lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org Developers" , qemu-stable@nongnu.org, Patch Tracking On Tue, Sep 12, 2017 at 9:13 AM, Peter Maydell wrote: > Fix an error that meant we were wiring every UART's overflow > interrupts into the same inputs 0 and 1 of the OR gate, > rather than giving each its own input. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Peter Maydell Reviewed-by: Alistair Francis Thanks, Alistair > --- > hw/arm/mps2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c > index abb0ab6..769cff8 100644 > --- a/hw/arm/mps2.c > +++ b/hw/arm/mps2.c > @@ -287,8 +287,8 @@ static void mps2_common_init(MachineState *machine) > cmsdk_apb_uart_create(uartbase[i], > qdev_get_gpio_in(txrx_orgate_dev, 0), > qdev_get_gpio_in(txrx_orgate_dev, 1), > - qdev_get_gpio_in(orgate_dev, 0), > - qdev_get_gpio_in(orgate_dev, 1), > + qdev_get_gpio_in(orgate_dev, i * 2), > + qdev_get_gpio_in(orgate_dev, i * 2 + 1), > NULL, > uartchr, SYSCLK_FRQ); > } > -- > 2.7.4 > >