From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52086)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1WGeMr-0008D7-70
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:53:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1WGeMq-0005xv-66
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:53:29 -0500
Received: from mail-oa0-x236.google.com ([2607:f8b0:4003:c02::236]:33134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alistair23@gmail.com>) id 1WGeMq-0005xm-1V
	for qemu-devel@nongnu.org; Thu, 20 Feb 2014 19:53:28 -0500
Received: by mail-oa0-f54.google.com with SMTP id g12so2776312oah.41
	for <qemu-devel@nongnu.org>; Thu, 20 Feb 2014 16:53:27 -0800 (PST)
MIME-Version: 1.0
Sender: alistair23@gmail.com
In-Reply-To: <CAFEAcA-D4gM2cwRAtOLcQFJZ+7hpmXdb-Zaobp0QeRHuzqYZCA@mail.gmail.com>
References: <57a391d51a6430e74fad5b88316c504b9217c306.1392853953.git.alistair.francis@xilinx.com>
	<CAFEAcA9DCW6qyw+ptxTQ1FT5=3_-BATPHBrFP5TxFH4f2UrP0g@mail.gmail.com>
	<CAKmqyKNJPSaZ5+NWrDVsbafhUorTWu99wWJjvqea8EjP=K4DtA@mail.gmail.com>
	<CAFEAcA-D4gM2cwRAtOLcQFJZ+7hpmXdb-Zaobp0QeRHuzqYZCA@mail.gmail.com>
From: Alistair Francis <alistair.francis@xilinx.com>
Date: Fri, 21 Feb 2014 10:52:56 +1000
Message-ID: <CAKmqyKPC=07YLWH57Bk2R+Nf9uq4xhhq_+rA=tom9CF2GCnwpA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH target-arm v7 1/1] target-arm: Implements
 the ARM PMCCNTR register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, QEMU Developers <qemu-devel@nongnu.org>, Alistair Francis <alistair.francis@xilinx.com>

On Fri, Feb 21, 2014 at 10:07 AM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 20 February 2014 23:58, Alistair Francis <alistair.francis@xilinx.com> wrote:
>> On Fri, Feb 21, 2014 at 1:44 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> This breaks compilation of the arm-linux-user target
>>> (the qemu_clock_get_* functions are only available in
>>> system mode). You probably want to do something similar
>>> to how we handle the generic timers, where we #ifdef
>>> everything out. (I don't think Linux gives user
>>> space access to the perf monitor registers.)
>
>> What do you think the functions should do when in user space? Should
>> they just return 0?
>
> Just don't define reginfo entries for them at all -- then we will
> UNDEF because the lookup will return no result. This is what
> the generic timer code does.
>
> thanks
> -- PMM
>

Ok, so if it is user mode, it just treats the pmccntr register exactly
as it does before the patch. I've implemented that and it seems to
work. I'll submit the patch now