* [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet
@ 2017-02-08 17:57 Thomas Huth
2017-02-09 7:27 ` Markus Armbruster
2017-02-15 10:14 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2017-02-08 17:57 UTC (permalink / raw)
To: Alistair Francis, qemu-devel; +Cc: qemu-trivial, Markus Armbruster
The "qemu,register" device needs to be wired up in source code, there
is no way the user can make any real use of this device with the
"-device" parameter or the "device_add" monitor command yet.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
v3: Another update to the patch description and comment
hw/core/register.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/hw/core/register.c b/hw/core/register.c
index 4bfbc50..be170dc 100644
--- a/hw/core/register.c
+++ b/hw/core/register.c
@@ -274,9 +274,18 @@ void register_finalize_block(RegisterInfoArray *r_array)
g_free(r_array);
}
+static void register_class_init(ObjectClass *oc, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(oc);
+
+ /* Reason: needs to be wired up to work */
+ dc->cannot_instantiate_with_device_add_yet = true;
+}
+
static const TypeInfo register_info = {
.name = TYPE_REGISTER,
.parent = TYPE_DEVICE,
+ .class_init = register_class_init,
};
static void register_register_types(void)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet
2017-02-08 17:57 [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet Thomas Huth
@ 2017-02-09 7:27 ` Markus Armbruster
2017-02-11 1:10 ` Alistair Francis
2017-02-15 10:14 ` Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2017-02-09 7:27 UTC (permalink / raw)
To: Thomas Huth; +Cc: Alistair Francis, qemu-devel, qemu-trivial
Thomas Huth <thuth@redhat.com> writes:
> The "qemu,register" device needs to be wired up in source code, there
> is no way the user can make any real use of this device with the
> "-device" parameter or the "device_add" monitor command yet.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet
2017-02-09 7:27 ` Markus Armbruster
@ 2017-02-11 1:10 ` Alistair Francis
0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2017-02-11 1:10 UTC (permalink / raw)
To: Markus Armbruster
Cc: Thomas Huth, QEMU Trivial, qemu-devel@nongnu.org Developers,
Alistair Francis
On Wed, Feb 8, 2017 at 11:27 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Thomas Huth <thuth@redhat.com> writes:
>
>> The "qemu,register" device needs to be wired up in source code, there
>> is no way the user can make any real use of this device with the
>> "-device" parameter or the "device_add" monitor command yet.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Thanks,
Alistair
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet
2017-02-08 17:57 [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet Thomas Huth
2017-02-09 7:27 ` Markus Armbruster
@ 2017-02-15 10:14 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2017-02-15 10:14 UTC (permalink / raw)
To: Thomas Huth, Alistair Francis, qemu-devel; +Cc: qemu-trivial, Markus Armbruster
08.02.2017 20:57, Thomas Huth wrote:
> The "qemu,register" device needs to be wired up in source code, there
> is no way the user can make any real use of this device with the
> "-device" parameter or the "device_add" monitor command yet.
Applied both v3 patches to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-15 10:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-08 17:57 [Qemu-devel] [PATCH v3] hw/core/register: Mark the device with cannot_instantiate_with_device_add_yet Thomas Huth
2017-02-09 7:27 ` Markus Armbruster
2017-02-11 1:10 ` Alistair Francis
2017-02-15 10:14 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).