From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Hans-Erik Floryd" <hans-erik.floryd@rt-labs.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>
Subject: Re: [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read
Date: Mon, 23 Oct 2023 11:36:33 +1000 [thread overview]
Message-ID: <CAKmqyKPJoyMmoNAX9JrHz6_SSphqRkEJPy3AUaV0eu+701Ow9g@mail.gmail.com> (raw)
In-Reply-To: <20231020170009.86870-3-philmd@linaro.org>
On Sat, Oct 21, 2023 at 4:12 AM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
>
> From: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
>
> Signed-off-by: Hans-Erik Floryd <hans-erik.floryd@rt-labs.com>
> [PMD: Split from bigger patch]
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Is this required?
I don't think this is required
Alistair
> ---
> hw/char/stm32f2xx_usart.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/stm32f2xx_usart.c b/hw/char/stm32f2xx_usart.c
> index 519d3461a3..46e29089bc 100644
> --- a/hw/char/stm32f2xx_usart.c
> +++ b/hw/char/stm32f2xx_usart.c
> @@ -109,6 +109,7 @@ static uint64_t stm32f2xx_usart_read(void *opaque, hwaddr addr,
> case USART_SR:
> retvalue = s->usart_sr;
> qemu_chr_fe_accept_input(&s->chr);
> + stm32f2xx_update_irq(s);
> return retvalue;
> case USART_DR:
> DB_PRINT("Value: 0x%" PRIx32 ", %c\n", s->usart_dr, (char) s->usart_dr);
> --
> 2.41.0
>
>
next prev parent reply other threads:[~2023-10-23 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 17:00 [PATCH v2 0/4] stm32f2xx_usart: implement TX interrupts Philippe Mathieu-Daudé
2023-10-20 17:00 ` [PATCH v2 1/4] hw/char/stm32f2xx_usart: Extract common IRQ update code to update_irq() Philippe Mathieu-Daudé
2023-10-22 16:53 ` Richard Henderson
2023-10-23 1:34 ` Alistair Francis
2023-10-20 17:00 ` [PATCH v2 2/4] hw/char/stm32f2xx_usart: Update IRQ when SR is read Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:36 ` Alistair Francis [this message]
2023-10-23 9:38 ` Hans-Erik Floryd
2023-10-20 17:00 ` [PATCH v2 3/4] hw/char/stm32f2xx_usart: Update IRQ when DR is written Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:37 ` Alistair Francis
2023-10-20 17:00 ` [PATCH v2 4/4] hw/char/stm32f2xx_usart: Add more definitions for CR1 register Philippe Mathieu-Daudé
2023-10-22 16:54 ` Richard Henderson
2023-10-23 1:38 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPJoyMmoNAX9JrHz6_SSphqRkEJPy3AUaV0eu+701Ow9g@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=hans-erik.floryd@rt-labs.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).