From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56FA9C4321A for ; Fri, 28 Jun 2019 16:36:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 249B82083B for ; Fri, 28 Jun 2019 16:36:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uztqS68f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 249B82083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgtr2-0008DL-Cz for qemu-devel@archiver.kernel.org; Fri, 28 Jun 2019 12:36:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34894) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgtMf-0002oe-UE for qemu-devel@nongnu.org; Fri, 28 Jun 2019 12:04:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgtMe-0000ym-1T for qemu-devel@nongnu.org; Fri, 28 Jun 2019 12:04:41 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:34897) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgtMc-0000sh-Ie; Fri, 28 Jun 2019 12:04:39 -0400 Received: by mail-lf1-x142.google.com with SMTP id a25so4331118lfg.2; Fri, 28 Jun 2019 09:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5dGU74xjYmsrypBQMVhsWiBTBztQOu4PtmKJ8sUHT2g=; b=uztqS68f0BdHeo3tc+fr2QKH14VfYOSPZAodaS7py4Hu7shbOw3jL8RSZ7xzwwg09D 2qesWTYh1C4754/6YW66PWcY39Bk4UyHcdIsswQgML80d3nRNkVdZKcU8k26nrFeDIT4 uw8XPRueagyGslP2S70I4REWtA2HRweTExTt9jpbSQRfr4X0IvQ5XfOLnNvLCB68Pxeg 0NAvq15A2baKZ+55F2bre+Q6wGrKYqncvJO6OjOp63q9c/VEe/+inTzK9ZwVrNjM8vGI f9Z6gxfIGWlrjWt3X96WzBKEjG9mBHukQHS8FjGq3l+CyA8quvdO9CvNpHogEVKKvPbf wCVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5dGU74xjYmsrypBQMVhsWiBTBztQOu4PtmKJ8sUHT2g=; b=fwHxMI8Uxq6rCqrtLX+w5hW4VVqRtPN90uKJQHxyuAe285nUpkiyLZFsuQanYhQSL6 hOHhmB5QfVPol5slp4MP/a/W5wRe1GRedqVrQBSccTCZeqQdzQUDkeXGZA0Ai1jXi35x kGE8dz0Bvppr4spwzRsvunSoEBVngKCIVWrpQm4zhR8eJbADjG7epIYmtH6illjGpxGN UW+PBqLQ69Dx8N0RnIEYVVer9w3/x9Oj+c6mxwVudF3bbuPWjryAKL+JpUYYIUGjpHXk E8Udxgutgr2YQQ6+Z5tSXK4mmbB5IUA0F5cViJn83BK0qP0p0F0C8ZirivNAp0wm3SpG BLmw== X-Gm-Message-State: APjAAAWVIxL97HcWgouNwdQAbHi/Osn6EcH6fVBbluVw8jxzkEUqmV2S gBnyfaytGherJ9x3AcuY3iTJZroht0tYlepP0BD4X5tYxY4= X-Google-Smtp-Source: APXvYqwF7e0zx1tQvrQedR6htzRevSsC2E4lPPRr2FGufD1LNIirVxkhJrVWH2LiqHancWBbZP+64KpOKk7LktBt9Gk= X-Received: by 2002:a05:6512:29a:: with SMTP id j26mr5269037lfp.44.1561737872461; Fri, 28 Jun 2019 09:04:32 -0700 (PDT) MIME-Version: 1.0 References: <20190627202719.17739-1-philmd@redhat.com> <20190627202719.17739-8-philmd@redhat.com> In-Reply-To: <20190627202719.17739-8-philmd@redhat.com> From: Alistair Francis Date: Fri, 28 Jun 2019 09:01:32 -0700 Message-ID: To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 Subject: Re: [Qemu-devel] [PATCH v5 07/28] hw/block/pflash_cfi02: Simplify a statement using fall through X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Stephen Checkoway , "qemu-devel@nongnu.org Developers" , "Edgar E. Iglesias" , Qemu-block , John Snow , Magnus Damm , Markus Armbruster , Antony Pavlov , Laurent Vivier , Thomas Huth , Alistair Francis , qemu-arm , Jan Kiszka , =?UTF-8?B?QWxleCBCZW5uw6ll?= , David Gibson , Kevin Wolf , Max Reitz , Michael Walle , "open list:New World" , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jun 27, 2019 at 1:31 PM Philippe Mathieu-Daud=C3=A9 wrote: > > Signed-off-by: Stephen Checkoway > Message-Id: <20190426162624.55977-3-stephen.checkoway@oberlin.edu> > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > Tested-by: Philippe Mathieu-Daud=C3=A9 > [PMD: Extracted from bigger patch] > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > hw/block/pflash_cfi02.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c > index e9eea0ec08..9e8c28af8f 100644 > --- a/hw/block/pflash_cfi02.c > +++ b/hw/block/pflash_cfi02.c > @@ -239,10 +239,10 @@ static uint32_t pflash_read(PFlashCFI02 *pfl, hwadd= r offset, > case 0x0E: > case 0x0F: > ret =3D boff & 0x01 ? pfl->ident3 : pfl->ident2; > - if (ret =3D=3D (uint8_t)-1) { > - goto flash_read; > + if (ret !=3D (uint8_t)-1) { > + break; > } > - break; > + /* Fall through to data read. */ > default: > goto flash_read; > } > -- > 2.20.1 > >