From: Alistair Francis <alistair23@gmail.com>
To: Edgar Iglesias <edgar.iglesias@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>,
figlesia@xilinx.com, "Peter Maydell" <peter.maydell@linaro.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Edgar Iglesias" <edgar.iglesias@xilinx.com>,
"Sai Pavan Boddu" <sai.pavan.boddu@xilinx.com>,
"Francisco Iglesias" <frasse.iglesias@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"KONRAD Frederic" <frederic.konrad@adacore.com>,
muhammad_bilal@mentor.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Luc Michel" <luc.michel@greensocs.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/4] hw/arm: versal: Remove bogus virtio-mmio creation
Date: Thu, 29 Nov 2018 12:52:01 -0800 [thread overview]
Message-ID: <CAKmqyKPPz0oz_ZcegsySRVc+=bw3Hkm1VUVVucfCmwGG0_ipeQ@mail.gmail.com> (raw)
In-Reply-To: <20181129163655.20370-2-edgar.iglesias@gmail.com>
On Thu, Nov 29, 2018 at 8:37 AM Edgar E. Iglesias
<edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Remove bogus virtio-mmio creation. This was an accidental
> left-over an experiment.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/arm/xlnx-versal-virt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
> index 1e31a3f442..41b8d801c8 100644
> --- a/hw/arm/xlnx-versal-virt.c
> +++ b/hw/arm/xlnx-versal-virt.c
> @@ -364,7 +364,6 @@ static void create_virtio_regions(VersalVirt *s)
> sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
> mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
> memory_region_add_subregion(&s->soc.mr_ps, base, mr);
> - sysbus_create_simple("virtio-mmio", base, pic_irq);
> }
>
> for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2018-11-29 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 16:36 [Qemu-devel] [PATCH v1 0/4] hw/arm: versal: Correct number of IRQs in GIC setup Edgar E. Iglesias
2018-11-29 16:36 ` [Qemu-devel] [PATCH v1 1/4] hw/arm: versal: Remove bogus virtio-mmio creation Edgar E. Iglesias
2018-11-29 20:52 ` Alistair Francis [this message]
2018-11-30 8:38 ` Luc Michel
2018-11-29 16:36 ` [Qemu-devel] [PATCH v1 2/4] hw/arm: versal: Reduce number of virtio-mmio instances Edgar E. Iglesias
2018-11-29 20:52 ` Alistair Francis
2018-11-29 16:36 ` [Qemu-devel] [PATCH v1 3/4] hw/arm: versal: Use IRQs 111 - 118 for virtio-mmio Edgar E. Iglesias
2018-11-30 17:38 ` Alistair Francis
2018-11-29 16:36 ` [Qemu-devel] [PATCH v1 4/4] hw/arm: versal: Correct the nr of IRQs to 192 Edgar E. Iglesias
2018-11-29 23:10 ` Alistair Francis
2018-12-03 18:48 ` [Qemu-devel] [PATCH v1 0/4] hw/arm: versal: Correct number of IRQs in GIC setup Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPPz0oz_ZcegsySRVc+=bw3Hkm1VUVVucfCmwGG0_ipeQ@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=muhammad_bilal@mentor.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).