qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: "hemanshu.khilari.foss" <hemanshu.khilari.foss@gmail.com>
Cc: qemu-devel@nongnu.org, Alistair.Francis@wdc.com, qemu-riscv@nongnu.org
Subject: Re: [PATCH v3] docs/specs/riscv-iommu: Fixed broken link to external risv iommu document
Date: Mon, 24 Mar 2025 12:11:28 +1000	[thread overview]
Message-ID: <CAKmqyKPYggbUzd2MOVhu7KwKYGgBGD3KVy31JiTSFWX2QL-_Uw@mail.gmail.com> (raw)
In-Reply-To: <20250323063404.13206-1-hemanshu.khilari.foss@gmail.com>

On Sun, Mar 23, 2025 at 4:36 PM hemanshu.khilari.foss
<hemanshu.khilari.foss@gmail.com> wrote:
>
> The links to riscv iommu specification document are incorrect. This patch
> updates all the said link to point to correct location.
>
> Cc: qemu-riscv@nongnu.org
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2808
> Signed-off-by: hemanshu.khilari.foss <hemanshu.khilari.foss@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  docs/specs/riscv-iommu.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/specs/riscv-iommu.rst b/docs/specs/riscv-iommu.rst
> index 000c7e1f57..991d376fdc 100644
> --- a/docs/specs/riscv-iommu.rst
> +++ b/docs/specs/riscv-iommu.rst
> @@ -4,7 +4,7 @@ RISC-V IOMMU support for RISC-V machines
>  ========================================
>
>  QEMU implements a RISC-V IOMMU emulation based on the RISC-V IOMMU spec
> -version 1.0 `iommu1.0`_.
> +version 1.0 `iommu1.0.0`_.
>
>  The emulation includes a PCI reference device (riscv-iommu-pci) and a platform
>  bus device (riscv-iommu-sys) that QEMU RISC-V boards can use.  The 'virt'
> @@ -14,7 +14,7 @@ riscv-iommu-pci reference device
>  --------------------------------
>
>  This device implements the RISC-V IOMMU emulation as recommended by the section
> -"Integrating an IOMMU as a PCIe device" of `iommu1.0`_: a PCI device with base
> +"Integrating an IOMMU as a PCIe device" of `iommu1.0.0`_: a PCI device with base
>  class 08h, sub-class 06h and programming interface 00h.
>
>  As a reference device it doesn't implement anything outside of the specification,
> @@ -109,7 +109,7 @@ riscv-iommu options:
>  - "s-stage": enabled
>  - "g-stage": enabled
>
> -.. _iommu1.0: https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf
> +.. _iommu1.0.0: https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0.0/riscv-iommu.pdf
>
>  .. _linux-v8: https://lore.kernel.org/linux-riscv/cover.1718388908.git.tjeznach@rivosinc.com/
>
> --
> 2.42.0
>
>


  reply	other threads:[~2025-03-24  2:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-23  6:34 [PATCH v3] docs/specs/riscv-iommu: Fixed broken link to external risv iommu document hemanshu.khilari.foss
2025-03-24  2:11 ` Alistair Francis [this message]
2025-03-24  2:41 ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKPYggbUzd2MOVhu7KwKYGgBGD3KVy31JiTSFWX2QL-_Uw@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=hemanshu.khilari.foss@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).