From: Alistair Francis <alistair23@gmail.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, peter.maydell@linaro.org
Subject: Re: [PATCH v3 2/5] softmmu: pass the main loop status to gdb "Wxx" packet
Date: Mon, 18 Sep 2023 12:05:35 +1000 [thread overview]
Message-ID: <CAKmqyKPYkRF_AFmbw5-gvRn_6pD30yUaAng-oc1=MsYcyPT2oA@mail.gmail.com> (raw)
In-Reply-To: <20230907112640.292104-3-chigot@adacore.com>
On Thu, Sep 7, 2023 at 9:26 PM Clément Chigot <chigot@adacore.com> wrote:
>
> gdb_exit function aims to close gdb sessions and sends the exit code of
> the current execution. It's being called by qemu_cleanup once the main
> loop is over.
> Until now, the exit code sent was always 0. Now that hardware can
> shutdown this main loop with custom exit codes, these codes must be
> transfered to gdb as well.
>
> Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> include/sysemu/sysemu.h | 2 +-
> softmmu/main.c | 2 +-
> softmmu/runstate.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
> index 25be2a692e..73a37949c2 100644
> --- a/include/sysemu/sysemu.h
> +++ b/include/sysemu/sysemu.h
> @@ -101,7 +101,7 @@ bool defaults_enabled(void);
>
> void qemu_init(int argc, char **argv);
> int qemu_main_loop(void);
> -void qemu_cleanup(void);
> +void qemu_cleanup(int);
>
> extern QemuOptsList qemu_legacy_drive_opts;
> extern QemuOptsList qemu_common_drive_opts;
> diff --git a/softmmu/main.c b/softmmu/main.c
> index 694388bd7f..9b91d21ea8 100644
> --- a/softmmu/main.c
> +++ b/softmmu/main.c
> @@ -35,7 +35,7 @@ int qemu_default_main(void)
> int status;
>
> status = qemu_main_loop();
> - qemu_cleanup();
> + qemu_cleanup(status);
>
> return status;
> }
> diff --git a/softmmu/runstate.c b/softmmu/runstate.c
> index ee27e26048..d4e2e59e45 100644
> --- a/softmmu/runstate.c
> +++ b/softmmu/runstate.c
> @@ -794,9 +794,9 @@ void qemu_init_subsystems(void)
> }
>
>
> -void qemu_cleanup(void)
> +void qemu_cleanup(int status)
> {
> - gdb_exit(0);
> + gdb_exit(status);
>
> /*
> * cleaning up the migration object cancels any existing migration
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-09-18 2:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 11:26 [PATCH v3 0/5] Risc-V/gdb: replace exit calls with proper shutdown Clément Chigot
2023-09-07 11:26 ` [PATCH v3 1/5] softmmu: add means to pass an exit code when requesting a shutdown Clément Chigot
2023-09-18 2:03 ` Alistair Francis
2023-09-07 11:26 ` [PATCH v3 2/5] softmmu: pass the main loop status to gdb "Wxx" packet Clément Chigot
2023-09-18 2:05 ` Alistair Francis [this message]
2023-09-07 11:26 ` [PATCH v3 3/5] hw/misc/sifive_test.c: replace exit calls with proper shutdown Clément Chigot
2023-09-18 2:06 ` Alistair Francis
2023-09-07 11:26 ` [PATCH v3 4/5] hw/char: riscv_htif: " Clément Chigot
2023-09-18 2:07 ` Alistair Francis
2023-09-22 5:20 ` Alistair Francis
2023-10-02 9:32 ` Clément Chigot
2023-10-09 1:21 ` Alistair Francis
2023-09-07 11:26 ` [PATCH v3 5/5] gdbstub: replace exit calls with proper shutdown for softmmu Clément Chigot
2023-09-18 2:09 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPYkRF_AFmbw5-gvRn_6pD30yUaAng-oc1=MsYcyPT2oA@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=chigot@adacore.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).