qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@xilinx.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Alistair Francis" <alistair.francis@xilinx.com>
Subject: Re: [Qemu-devel] [PATCH RESEND v1 1/5] target-microblaze: Fix up indentation
Date: Thu, 28 May 2015 10:37:03 +1000	[thread overview]
Message-ID: <CAKmqyKPYvsCwS5mqF3u3EjZ+1rFnHTOJqVXvFWbeihuWkitMog@mail.gmail.com> (raw)
In-Reply-To: <CAEgOgz7cATFUUdbK3YNgmY3R0D4Qm14yHSj0=3FmvDBV=_bCPQ@mail.gmail.com>

On Mon, May 25, 2015 at 1:44 PM, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> On Mon, May 18, 2015 at 4:12 PM, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
>> Fix up the incorrect indentation level in the helper_stackprot() function.
>>
>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>

Thanks

Alistair

>
>> ---
>>
>>  target-microblaze/op_helper.c |   10 +++++-----
>>  1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/target-microblaze/op_helper.c b/target-microblaze/op_helper.c
>> index a4c8f04..d2b3624 100644
>> --- a/target-microblaze/op_helper.c
>> +++ b/target-microblaze/op_helper.c
>> @@ -468,11 +468,11 @@ void helper_memalign(CPUMBState *env, uint32_t addr, uint32_t dr, uint32_t wr,
>>  void helper_stackprot(CPUMBState *env, uint32_t addr)
>>  {
>>      if (addr < env->slr || addr > env->shr) {
>> -            qemu_log("Stack protector violation at %x %x %x\n",
>> -                     addr, env->slr, env->shr);
>> -            env->sregs[SR_EAR] = addr;
>> -            env->sregs[SR_ESR] = ESR_EC_STACKPROT;
>> -            helper_raise_exception(env, EXCP_HW_EXCP);
>> +        qemu_log("Stack protector violation at %x %x %x\n",
>> +                 addr, env->slr, env->shr);
>> +        env->sregs[SR_EAR] = addr;
>> +        env->sregs[SR_ESR] = ESR_EC_STACKPROT;
>> +        helper_raise_exception(env, EXCP_HW_EXCP);
>>      }
>>  }
>>
>> --
>> 1.7.1
>>
>>
>

  reply	other threads:[~2015-05-28  0:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18  1:13 [Qemu-devel] [PATCH v1 0/5] Add Microblaze configuration options Alistair Francis
2015-05-18  1:13 ` [Qemu-devel] [PATCH v1 1/5] target-microblaze: Fix up indentation Alistair Francis
2015-05-25  3:44   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-05-28  0:37     ` Alistair Francis [this message]
2015-05-18  1:13 ` [Qemu-devel] [PATCH v1 2/5] target-microblaze: Preserve the pvr registers during reset Alistair Francis
2015-05-25  3:53   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-05-28  0:47     ` Alistair Francis
2015-05-18  1:13 ` [Qemu-devel] [PATCH v1 3/5] target-microblaze: Allow the stack protection to be disabled Alistair Francis
2015-05-25  4:07   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-05-26  1:55     ` Alistair Francis
2015-05-26  1:59       ` Peter Crosthwaite
2015-05-18  1:13 ` [Qemu-devel] [PATCH v1 4/5] target-microblaze: Tidy up the base-vectors property Alistair Francis
2015-05-25  4:09   ` [Qemu-devel] [PATCH RESEND " Peter Crosthwaite
2015-05-18 23:14 ` [Qemu-devel] [PATCH RESEND v1 5/5] target-microblaze: Convert use-fpu to a CPU property Alistair Francis
2015-05-25  4:34   ` Peter Crosthwaite
2015-05-28  1:02     ` Alistair Francis
2015-05-18 23:16 ` [Qemu-devel] [PATCH RESEND v1 0/5] Add Microblaze configuration options Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKPYvsCwS5mqF3u3EjZ+1rFnHTOJqVXvFWbeihuWkitMog@mail.gmail.com \
    --to=alistair.francis@xilinx.com \
    --cc=afaerber@suse.de \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).