From: Alistair Francis <alistair23@gmail.com>
To: Michael Clark <mjc@sifive.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 6/6] riscv64-softmmu.mak: Build Virtio Block support
Date: Tue, 10 Jul 2018 17:10:28 -0700 [thread overview]
Message-ID: <CAKmqyKPZ6PYuHo1rEEKauBjLRFxwnABXW6Qi2270YoXZPah7dQ@mail.gmail.com> (raw)
In-Reply-To: <CAHNT7NvN42K7J+G2+PDzkb7btnGykpzrGjd9zFMx8Oh0SHHMfg@mail.gmail.com>
On Mon, Jul 9, 2018 at 6:54 PM, Michael Clark <mjc@sifive.com> wrote:
>
>
> On Tue, 10 Jul 2018 at 12:29 PM, Alistair Francis <alistair.francis@wdc.com>
> wrote:
>>
>> Add build time support for the VirtIO block device. This allows us to
>> attach a drive using the virtio-blk-device.
>
>
> I’m not sure what has changed in master, but VirtIO block and net for both
> softmmu-riscv32 and softmmu-riscv64 were previously building by default and
> working. Perhaps i’ve missed some patches that split up VirtIO support into
> more granular config options.
It just occurred to me that this patch might not be required. Someone
my last patch series had a conflict that results in removing the virt
include in the default configs. I suspect this patch can be dropped.
Alistair
>
> In any case, we should enable both CONFIG_VIRTIO_NET and CONFIG_VIRTIO_BLK
> for both riscv32 and riscv64 as these were working in QEMU 2.12. There are
> folk using the “virt” machine for riscv32 Linux.
>
> Thanks, at least I know what to expect when I rebase my patch queue against
> master and of course make a PR for the reviewed patches...
>
> I’m not sure of the soft-freeze date but the bulk of the patches are the
> same ones that were posted about a month ago... I also have several patches
> that are not yet on the list...
>
> Vectored interrupts. Trap tracing. More spec wording clarifications
> regarding load reservations and interrupts:
>
> -
> https://github.com/riscv/riscv-qemu/commits/qemu-2.13-for-upstream
>
> Michael
>
>> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> ---
>> default-configs/riscv64-softmmu.mak | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/default-configs/riscv64-softmmu.mak
>> b/default-configs/riscv64-softmmu.mak
>> index 35e74bebe9..8790f3b115 100644
>> --- a/default-configs/riscv64-softmmu.mak
>> +++ b/default-configs/riscv64-softmmu.mak
>> @@ -12,3 +12,5 @@ CONFIG_PCI_XILINX=y
>>
>> CONFIG_VGA=y
>> CONFIG_VGA_PCI=y
>> +
>> +CONFIG_VIRTIO_BLK=y
>> --
>> 2.17.1
>>
>
next prev parent reply other threads:[~2018-07-11 0:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 0:27 [Qemu-devel] [PATCH v2 0/6] Connect a PCIe host and graphics support to RISC-V Alistair Francis
2018-07-10 0:27 ` [Qemu-devel] [PATCH v2 1/6] hw/riscv/virtio: Set the soc device tree node as a simple-bus Alistair Francis
2018-07-10 0:28 ` [Qemu-devel] [PATCH v2 2/6] hw/riscv/virt: Increase the number of interrupts Alistair Francis
2018-07-10 0:28 ` [Qemu-devel] [PATCH v2 3/6] hw/riscv/virt: Connect the gpex PCIe Alistair Francis
2018-07-10 0:28 ` [Qemu-devel] [PATCH v2 4/6] hw/riscv/virt: Connect a VGA PCIe device Alistair Francis
2018-07-10 0:28 ` [Qemu-devel] [PATCH v2 5/6] hw/riscv/sifive_u: Connect the Xilinx PCIe Alistair Francis
2018-07-10 0:28 ` [Qemu-devel] [PATCH v2 6/6] riscv64-softmmu.mak: Build Virtio Block support Alistair Francis
2018-07-10 1:54 ` Michael Clark
2018-07-11 0:10 ` Alistair Francis [this message]
2018-07-11 0:14 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPZ6PYuHo1rEEKauBjLRFxwnABXW6Qi2270YoXZPah7dQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=mjc@sifive.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).