From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMFqx-0001lp-8C for qemu-devel@nongnu.org; Thu, 02 May 2019 13:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMFqw-0008Rq-7Y for qemu-devel@nongnu.org; Thu, 02 May 2019 13:50:39 -0400 MIME-Version: 1.0 References: <20190501094006.GN29808@redhat.com> In-Reply-To: <20190501094006.GN29808@redhat.com> From: Alistair Francis Date: Thu, 2 May 2019 10:48:39 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Cc: Alistair Francis , "qemu-devel@nongnu.org" , "kraxel@redhat.com" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , "qemu-trivial@nongnu.org" On Wed, May 1, 2019 at 2:40 AM Daniel P. Berrang=C3=A9 wrote: > > On Tue, Apr 30, 2019 at 11:28:41PM +0000, Alistair Francis wrote: > > Fix this warning with GCC 9 on Fedora 30: > > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of =E2= =80=98struct =E2=80=99 may result in an unaligned pointer value = [-Werror=3Daddress-of-packed-member] > > 1715 | dataset->filename); > > | ~~~~~~~^~~~~~~~~~ > > > > Signed-off-by: Alistair Francis > > --- > > hw/usb/dev-mtp.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > > index 99548b012d..8233beacab 100644 > > --- a/hw/usb/dev-mtp.c > > +++ b/hw/usb/dev-mtp.c > > @@ -1711,9 +1711,22 @@ static void usb_mtp_write_metadata(MTPState *s, = uint64_t dlen) > > assert(!s->write_pending); > > assert(p !=3D NULL); > > > > +/* > > + * We are about to access a packed struct. We are confident that the p= ointer > > + * address won't be unaligned, so we ignore GCC warnings. > > + */ > > The data is mis-aligned as we're accessing an int16 array that > is immediately following an int8 field in a packed struct > > This problem is fixed by the following series which Gerd has in the > USB queue: > > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02524.html Great, that fixes the build issues. Dropping this patch. Alistair > > > +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9,= 0) > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" > > +#endif > > + > > filename =3D utf16_to_str(MIN(dataset->length, filename_chars), > > dataset->filename); > > > > +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9,= 0) > > +#pragma GCC diagnostic pop > > +#endif > > + > > if (strchr(filename, '/')) { > > usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans, > > 0, 0, 0, 0); > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| > |: https://libvirt.org -o- https://fstop138.berrange.c= om :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C7E4C43219 for ; Thu, 2 May 2019 17:52:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 165352081C for ; Thu, 2 May 2019 17:52:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KxHrW0D+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 165352081C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:56678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMFsO-00036U-73 for qemu-devel@archiver.kernel.org; Thu, 02 May 2019 13:52:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMFqx-0001lp-8C for qemu-devel@nongnu.org; Thu, 02 May 2019 13:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMFqw-0008Rq-7Y for qemu-devel@nongnu.org; Thu, 02 May 2019 13:50:39 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:38963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMFqv-0008Qz-Te; Thu, 02 May 2019 13:50:38 -0400 Received: by mail-lf1-x142.google.com with SMTP id d12so2539726lfk.6; Thu, 02 May 2019 10:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=S0HcZYmG35XwM3FB6c/bLgB9OB0qv2fbqqJQy3dSZUY=; b=KxHrW0D+mcunpIG0R4LcBRpuuTZGBpWNzNb2YCaK0a3MUg6vexmGfYmRLfMKpfs8kM tbcouZF4Yryl6z5fpu2nJanExmdH4NbZdo5pJxw+Xj1y3fw59W12CMoKOqpSCp9eQvhu AsPvMd2I9EXLy7FgTsRVv6eKOtW0U2Gn3BT2C0oSD6g9qIEX2t4Qv/K+1miutF9Pe296 KnibS7NAzEh7opm7+XSyx+mL6WBPQbaCxpTOJDALw+AOFCb2qcOTU+usM5qv4bYqIHVp WxctIbDjek2p59KMoArIqonVJQ1J0/IKXl6tF6o3T+0BqbL+h2dC0fTEdO5a0iaNm+ds grjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=S0HcZYmG35XwM3FB6c/bLgB9OB0qv2fbqqJQy3dSZUY=; b=GBwXXsBFxvQZyyOz+gZ8D80xJF0OE2y41uC+tzJIgOiIdTiwV8iVA85aA5Bfj1YqBA 1h7HZpyV+P1fnBBPnyXr6SRx23/hJvw8h8eK+Y9X7RWbBUmYt22joB7X4BtbTYU5x7fO PoC5xSGXqWUEHfbspOIFUup0B6nRm+0PBsgZBmk/c5tBM4F+rKNCFu68SpQiDyHf/v9J ACpvmB/KwGXkAQxTXQ6A1kcb3W1MPApTip5fYPi1uP6aTQ3gn8vWBjfo1LUHfhwLohLX yIiUIfFHDHy3N8zDfw5NS2pPhsJcCDYNoBZ0npPsFdZGf/bEpynHT44mf0TfKeos2hzh bp7A== X-Gm-Message-State: APjAAAUM3utKNIesjX+HueSc13hS8DHBoEXT+7dLiTjnzrkAGKH3CwUK u8GZiJ0qaTw40YO05kN24yNKHpNHMfkWQO7IXHo= X-Google-Smtp-Source: APXvYqxAdEkh3A3wZ910t1wUbE6KLTdNyCxyv81ZypOMgen+94wTJB4yMlUfCWVqFA1Dpwa7iqvTj7e8YRk3C0Q+934= X-Received: by 2002:a19:a40f:: with SMTP id q15mr2482037lfc.121.1556819436262; Thu, 02 May 2019 10:50:36 -0700 (PDT) MIME-Version: 1.0 References: <20190501094006.GN29808@redhat.com> In-Reply-To: <20190501094006.GN29808@redhat.com> From: Alistair Francis Date: Thu, 2 May 2019 10:48:39 -0700 Message-ID: To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 Subject: Re: [Qemu-devel] [PATCH v2 3/5] hw/usb/dev-mtp: Fix GCC 9 build warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-trivial@nongnu.org" , "riku.voipio@iki.fi" , "laurent@vivier.eu" , "qemu-devel@nongnu.org" , Alistair Francis , "kraxel@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190502174839.cksbgVIiCgulAMQHXkofkKPm94yMDc-8Dp5nLaEACNY@z> On Wed, May 1, 2019 at 2:40 AM Daniel P. Berrang=C3=A9 wrote: > > On Tue, Apr 30, 2019 at 11:28:41PM +0000, Alistair Francis wrote: > > Fix this warning with GCC 9 on Fedora 30: > > hw/usb/dev-mtp.c:1715:36: error: taking address of packed member of =E2= =80=98struct =E2=80=99 may result in an unaligned pointer value = [-Werror=3Daddress-of-packed-member] > > 1715 | dataset->filename); > > | ~~~~~~~^~~~~~~~~~ > > > > Signed-off-by: Alistair Francis > > --- > > hw/usb/dev-mtp.c | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > > index 99548b012d..8233beacab 100644 > > --- a/hw/usb/dev-mtp.c > > +++ b/hw/usb/dev-mtp.c > > @@ -1711,9 +1711,22 @@ static void usb_mtp_write_metadata(MTPState *s, = uint64_t dlen) > > assert(!s->write_pending); > > assert(p !=3D NULL); > > > > +/* > > + * We are about to access a packed struct. We are confident that the p= ointer > > + * address won't be unaligned, so we ignore GCC warnings. > > + */ > > The data is mis-aligned as we're accessing an int16 array that > is immediately following an int8 field in a packed struct > > This problem is fixed by the following series which Gerd has in the > USB queue: > > https://lists.gnu.org/archive/html/qemu-devel/2019-04/msg02524.html Great, that fixes the build issues. Dropping this patch. Alistair > > > +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9,= 0) > > +#pragma GCC diagnostic push > > +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" > > +#endif > > + > > filename =3D utf16_to_str(MIN(dataset->length, filename_chars), > > dataset->filename); > > > > +#if defined(CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE) && QEMU_GNUC_PREREQ(9,= 0) > > +#pragma GCC diagnostic pop > > +#endif > > + > > if (strchr(filename, '/')) { > > usb_mtp_queue_result(s, RES_PARAMETER_NOT_SUPPORTED, d->trans, > > 0, 0, 0, 0); > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| > |: https://libvirt.org -o- https://fstop138.berrange.c= om :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|