From: Alistair Francis <alistair23@gmail.com>
To: Weiwei Li <liweiwei@iscas.ac.cn>
Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, palmer@dabbelt.com,
alistair.francis@wdc.com, bin.meng@windriver.com,
dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com,
richard.henderson@linaro.org, wangjunqiang@iscas.ac.cn,
lazyparser@gmail.com
Subject: Re: [PATCH v5 06/13] target/riscv: Remove unused paramters in pmp_hart_has_privs_default()
Date: Wed, 17 May 2023 12:09:35 +1000 [thread overview]
Message-ID: <CAKmqyKPc=mDqXta_hgVgt86GRzCmsdD6wb05upqPpeRLsw5XZg@mail.gmail.com> (raw)
In-Reply-To: <20230428143621.142390-7-liweiwei@iscas.ac.cn>
On Sat, Apr 29, 2023 at 12:38 AM Weiwei Li <liweiwei@iscas.ac.cn> wrote:
>
> The addr and size parameters in pmp_hart_has_privs_default() are unused.
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/pmp.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
> index e745842973..d2d8429277 100644
> --- a/target/riscv/pmp.c
> +++ b/target/riscv/pmp.c
> @@ -236,8 +236,7 @@ static int pmp_is_in_range(CPURISCVState *env, int pmp_index,
> /*
> * Check if the address has required RWX privs when no PMP entry is matched.
> */
> -static bool pmp_hart_has_privs_default(CPURISCVState *env, target_ulong addr,
> - target_ulong size, pmp_priv_t privs,
> +static bool pmp_hart_has_privs_default(CPURISCVState *env, pmp_priv_t privs,
> pmp_priv_t *allowed_privs,
> target_ulong mode)
> {
> @@ -309,8 +308,7 @@ bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr,
>
> /* Short cut if no rules */
> if (0 == pmp_get_num_rules(env)) {
> - return pmp_hart_has_privs_default(env, addr, size, privs,
> - allowed_privs, mode);
> + return pmp_hart_has_privs_default(env, privs, allowed_privs, mode);
> }
>
> if (size == 0) {
> @@ -454,8 +452,7 @@ bool pmp_hart_has_privs(CPURISCVState *env, target_ulong addr,
>
> /* No rule matched */
> if (!ret) {
> - ret = pmp_hart_has_privs_default(env, addr, size, privs,
> - allowed_privs, mode);
> + ret = pmp_hart_has_privs_default(env, privs, allowed_privs, mode);
> }
>
> return ret;
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2023-05-17 2:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 14:36 [PATCH v5 00/13] target/riscv: Fix PMP related problem Weiwei Li
2023-04-28 14:36 ` [PATCH v5 01/13] target/riscv: Update pmp_get_tlb_size() Weiwei Li
2023-05-17 2:00 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 02/13] target/riscv: Move pmp_get_tlb_size apart from get_physical_address_pmp Weiwei Li
2023-05-17 2:05 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 03/13] target/riscv: Make the short cut really work in pmp_hart_has_privs Weiwei Li
2023-05-17 2:07 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 04/13] target/riscv: Change the return type of pmp_hart_has_privs() to bool Weiwei Li
2023-05-17 2:08 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 05/13] target/riscv: Make RLB/MML/MMWP bits writable only when Smepmp is enabled Weiwei Li
2023-05-17 2:14 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 06/13] target/riscv: Remove unused paramters in pmp_hart_has_privs_default() Weiwei Li
2023-05-17 2:09 ` Alistair Francis [this message]
2023-04-28 14:36 ` [PATCH v5 07/13] target/riscv: Flush TLB when MMWP or MML bits are changed Weiwei Li
2023-05-17 2:12 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 08/13] target/riscv: Update the next rule addr in pmpaddr_csr_write() Weiwei Li
2023-05-17 2:21 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 09/13] target/riscv: Flush TLB when pmpaddr is updated Weiwei Li
2023-04-28 14:36 ` [PATCH v5 10/13] target/riscv: Flush TLB only when pmpcfg/pmpaddr really changes Weiwei Li
2023-04-28 14:36 ` [PATCH v5 11/13] accel/tcg: Uncache the host address for instruction fetch when tlb size < 1 Weiwei Li
2023-04-28 14:36 ` [PATCH v5 12/13] target/riscv: Separate pmp_update_rule() in pmpcfg_csr_write Weiwei Li
2023-05-17 2:23 ` Alistair Francis
2023-04-28 14:36 ` [PATCH v5 13/13] target/riscv: Deny access if access is partially inside the PMP entry Weiwei Li
2023-05-17 2:23 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKmqyKPc=mDqXta_hgVgt86GRzCmsdD6wb05upqPpeRLsw5XZg@mail.gmail.com' \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=dbarboza@ventanamicro.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wangjunqiang@iscas.ac.cn \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).