qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Bin Meng <bin.meng@windriver.com>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	Anup Patel <anup@brainfault.org>
Subject: Re: [PATCH v4 7/7] Makefile: Ship the generic platform bios images for RISC-V
Date: Fri, 10 Jul 2020 11:36:24 -0700	[thread overview]
Message-ID: <CAKmqyKPf4YH9Ut1mTLRoRdk-aja6wTKS-FhA-5LynbCeajh-_Q@mail.gmail.com> (raw)
In-Reply-To: <1594357499-29068-8-git-send-email-bmeng.cn@gmail.com>

On Thu, Jul 9, 2020 at 10:11 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Update the install blob list to include the generic platform
> fw_dynamic bios images.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>

You didn't address the comments in v3.

Thinking about this more though it looks like we currently don't
install anything, so this is an improvement.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - change fw_jump to fw_dynamic in the Makefile
>
> Changes in v2:
> - new patch: Makefile: Ship the generic platform bios images for RISC-V
>
>  Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index f06b3ae..05e05bb 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -840,7 +840,9 @@ palcode-clipper \
>  u-boot.e500 u-boot-sam460-20100605.bin \
>  qemu_vga.ndrv \
>  edk2-licenses.txt \
> -hppa-firmware.img
> +hppa-firmware.img \
> +opensbi-riscv32-generic-fw_dynamic.bin opensbi-riscv32-generic-fw_dynamic.elf \
> +opensbi-riscv64-generic-fw_dynamic.bin opensbi-riscv64-generic-fw_dynamic.elf
>
>
>  DESCS=50-edk2-i386-secure.json 50-edk2-x86_64-secure.json \
> --
> 2.7.4
>
>


  reply	other threads:[~2020-07-10 18:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10  5:04 [PATCH v4 0/7] riscv: Switch to use generic platform fw_dynamic type opensbi bios images Bin Meng
2020-07-10  5:04 ` [PATCH v4 1/7] configure: Create symbolic links for pc-bios/*.elf files Bin Meng
2020-07-10  5:04 ` [PATCH v4 2/7] roms/opensbi: Upgrade from v0.7 to v0.8 Bin Meng
2020-07-10  5:04 ` [PATCH v4 3/7] roms/Makefile: Build the generic platform for RISC-V OpenSBI firmware Bin Meng
2020-07-10  5:04 ` [PATCH v4 4/7] hw/riscv: Use pre-built bios image of generic platform for virt & sifive_u Bin Meng
2020-07-11 17:24   ` Alistair Francis
2020-07-13  1:53     ` Bin Meng
2020-07-16  4:54       ` Bin Meng
2020-07-28 15:29         ` Alistair Francis
2020-07-28 15:45           ` Bin Meng
2020-07-28 18:16             ` Alistair Francis
2020-07-29  4:51               ` Bin Meng
2020-07-29  4:54                 ` Alistair Francis
2020-07-29  5:10                   ` Bin Meng
2020-08-03  6:51                     ` Bin Meng
2020-08-12  3:25                       ` Alistair Francis
2020-07-10  5:04 ` [PATCH v4 5/7] hw/riscv: spike: Change the default bios to use generic platform image Bin Meng
2020-07-10  5:04 ` [PATCH v4 6/7] gitlab-ci/opensbi: Update GitLab CI to build generic platform Bin Meng
2020-07-10  5:04 ` [PATCH v4 7/7] Makefile: Ship the generic platform bios images for RISC-V Bin Meng
2020-07-10 18:36   ` Alistair Francis [this message]
2020-07-11 17:18     ` Alistair Francis
2020-07-13  1:26       ` Bin Meng
2020-07-10 18:59 ` [PATCH v4 0/7] riscv: Switch to use generic platform fw_dynamic type opensbi bios images Alistair Francis
2020-07-10 19:02   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKPf4YH9Ut1mTLRoRdk-aja6wTKS-FhA-5LynbCeajh-_Q@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=anup@brainfault.org \
    --cc=bin.meng@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmerdabbelt@google.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).