From: Alistair Francis <alistair23@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH for-7.1?] linux-user/riscv: Align signal frame to 16 bytes
Date: Tue, 2 Aug 2022 09:01:13 +1000 [thread overview]
Message-ID: <CAKmqyKPgL5AaG9T92yfKFTzRhKuiezSThYoo-pwNB3MLrx53Bw@mail.gmail.com> (raw)
In-Reply-To: <20220729201942.30738-1-richard.henderson@linaro.org>
On Sat, Jul 30, 2022 at 6:19 AM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Follow the kernel's alignment, as we already noted.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1093
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> linux-user/riscv/signal.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/linux-user/riscv/signal.c b/linux-user/riscv/signal.c
> index 296e39fbf0..eaa168199a 100644
> --- a/linux-user/riscv/signal.c
> +++ b/linux-user/riscv/signal.c
> @@ -64,9 +64,7 @@ static abi_ulong get_sigframe(struct target_sigaction *ka,
>
> /* This is the X/Open sanctioned signal stack switching. */
> sp = target_sigsp(sp, ka) - framesize;
> -
> - /* XXX: kernel aligns with 0xf ? */
> - sp &= ~3UL; /* align sp on 4-byte boundary */
> + sp &= ~0xf;
>
> return sp;
> }
> --
> 2.34.1
>
>
prev parent reply other threads:[~2022-08-01 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 20:19 [PATCH for-7.1?] linux-user/riscv: Align signal frame to 16 bytes Richard Henderson
2022-08-01 7:29 ` Alistair Francis
2022-08-01 23:01 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPgL5AaG9T92yfKFTzRhKuiezSThYoo-pwNB3MLrx53Bw@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).