From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00409C54EBD for ; Mon, 9 Jan 2023 22:59:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pF16d-0003Q1-74; Mon, 09 Jan 2023 17:59:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pF16c-0003Pp-1x; Mon, 09 Jan 2023 17:59:02 -0500 Received: from mail-vs1-xe2e.google.com ([2607:f8b0:4864:20::e2e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pF16a-0000Ub-Bp; Mon, 09 Jan 2023 17:59:01 -0500 Received: by mail-vs1-xe2e.google.com with SMTP id i185so10455909vsc.6; Mon, 09 Jan 2023 14:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gPm+WM4ZBeQ371G8E1ItvrCVyCyvKwKJFgS/JWOihm0=; b=JAMTOPX1ysEsDezC+bv9HY4QqxXHQJBc72chyZQzDa6UvVgpInYYFZPJM/c6QgKYp4 PBS9/ysApEgp01uwN6eVQdtXwBLQwQlR4a3P/r5LzE46BPFvhTAMeGV4HPbsWJbt/8Os Yil2iNa7afpz11nV2s5UTNKvhdZi2r9FuxgII+K01ITdiu+aHO5DHT3Nhabf+dlygdoq 8ngcBNEqOMkWz7Kuu+V1Y6VVRenDHdJSu4Hismsvk0vf61BmIdivVQ5ee7BN74Qxt2Hx keHGWn6FYQplWRvXMvJBRr4IHeuETDQAKpQNpiOjJ2E8q+V+pJcN8b4VmwgK6PpZLnJ6 gy0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gPm+WM4ZBeQ371G8E1ItvrCVyCyvKwKJFgS/JWOihm0=; b=jD5hwUruG15yHHaEreP1qcLoH2DV5C/qdQJev1mSeZzBfXt+t07R3qckUoQzSDXPef aTbJPNqkoDsad7VFrdLSRCtWtKeVYXbonOweuyYWOsSBwEe79Jj6EK5l3LpvFCkMb9/c yMx3Yz8We2WEcVSQQXrCJtwEeT1U+TMONAY9Fpweo1i6bJnwMZl9207WCQKHnXTdlQl4 aaLczFnzsA9tEGErTfSMafhj7pfCH/8Cjln725sKl/VNaL6cjL73fLY8b+ERHQ10b38g c7fo5vXghEui6tOISno0eDq86g2YpmvYlFZ9ytnntvZo4hbSq7WqzO2jonTMxOsT6svN /XMw== X-Gm-Message-State: AFqh2kp1A5c2LNLKA61Rx8xFDQJQSPNP3+lWuTvBm4icc4gOMn/UAnGD 9yY4fOSfrKNoXNgf+mkWlozJ4pM0LvwPyqXouXQ= X-Google-Smtp-Source: AMrXdXtrMXauP7JHIctC95vhpS2jAye5ghJnVwAw53oEw1WpcsoXqOsyHemCK60ICo4h0EaQJ93UpS6YT3iZQqTQcyc= X-Received: by 2002:a05:6102:510e:b0:3b1:2b83:1861 with SMTP id bm14-20020a056102510e00b003b12b831861mr8658055vsb.10.1673305139027; Mon, 09 Jan 2023 14:58:59 -0800 (PST) MIME-Version: 1.0 References: <20230109055933.749233-1-cyruscyliu@gmail.com> In-Reply-To: <20230109055933.749233-1-cyruscyliu@gmail.com> From: Alistair Francis Date: Tue, 10 Jan 2023 08:58:32 +1000 Message-ID: Subject: Re: [PATCH] hw/display/xlnx_dp: fix overflow in xlnx_dp_aux_push_tx_fifo() To: Qiang Liu Cc: qemu-devel@nongnu.org, Alistair Francis , "Edgar E. Iglesias" , Peter Maydell , "open list:Xilinx ZynqMP and..." Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::e2e; envelope-from=alistair23@gmail.com; helo=mail-vs1-xe2e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 9, 2023 at 4:01 PM Qiang Liu wrote: > > This patch checks if the s->tx_fifo is full. > > Fixes: 58ac482a66de ("introduce xlnx-dp") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1424 > Reported-by: Qiang Liu > Signed-off-by: Qiang Liu Reviewed-by: Alistair Francis Alistair > --- > hw/display/xlnx_dp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c > index 972473d94f..617b394af2 100644 > --- a/hw/display/xlnx_dp.c > +++ b/hw/display/xlnx_dp.c > @@ -854,7 +854,11 @@ static void xlnx_dp_write(void *opaque, hwaddr offset, uint64_t value, > break; > case DP_AUX_WRITE_FIFO: { > uint8_t c = value; > - xlnx_dp_aux_push_tx_fifo(s, &c, 1); > + if (fifo8_is_full(&s->tx_fifo)) { > + qemu_log_mask(LOG_GUEST_ERROR, "xlnx_dp: TX fifo is full"); > + } else { > + xlnx_dp_aux_push_tx_fifo(s, &c, 1); > + } > break; > } > case DP_AUX_CLOCK_DIVIDER: > -- > 2.25.1 > >