Re: [PATCH 00/13] hw/riscv/virt: device tree reg cleanups

[Alistair Francis <alistair23@gmail.com>]

On Tue, Apr 29, 2025 at 4:20 PM Joel Stanley <joel@jms.id.au> wrote:
>
> This is a set of cleanups for the riscv virt machine device tree
> generation that apply on top of Daniel's recent series.
>
> Using dumpdtb the old and new device trees are identical for -M virt and
> -M virt,aia=aplic-imsic.
>
> The final patch is not meant for merging, but demonstrates bugs in the
> existing code when the reg property describes an address > 4GB.
>
> Based-on: 20250423110630.2249904-1-dbarboza@ventanamicro.com
>
> Joel Stanley (13):
>   hw/riscv/virt: Fix clint base address type
>   hw/riscv/virt: Use setprop_sized_cells for clint
>   hw/riscv/virt: Use setprop_sized_cells for memory
>   hw/riscv/virt: Use setprop_sized_cells for aplic
>   hw/riscv/virt: Use setprop_sized_cells for aclint
>   hw/riscv/virt: Use setprop_sized_cells for plic
>   hw/riscv/virt: Use setprop_sized_cells for virtio
>   hw/riscv/virt: Use setprop_sized_cells for reset
>   hw/riscv/virt: Use setprop_sized_cells for uart
>   hw/riscv/virt: Use setprop_sized_cells for rtc
>   hw/riscv/virt: Use setprop_sized_cells for iommu
>   hw/riscv/virt: Use setprop_sized_cells for pcie
>   NOMERGE: virt: Adjust devices so everything is > 4G

Thanks, for the series

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Can you send a v2 without patch 13 and not with two patch 1's?

Alistair

>
>  hw/riscv/virt.c | 108 ++++++++++++++++++++++++------------------------
>  1 file changed, 53 insertions(+), 55 deletions(-)
>
> --
> 2.47.2
>
>