From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73268C433DB for ; Mon, 1 Feb 2021 20:02:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02A9264D9D for ; Mon, 1 Feb 2021 20:02:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02A9264D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6fOd-00074o-Q1 for qemu-devel@archiver.kernel.org; Mon, 01 Feb 2021 15:02:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6fMc-0005GG-9n; Mon, 01 Feb 2021 14:59:58 -0500 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]:41337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6fMa-0006yc-If; Mon, 01 Feb 2021 14:59:58 -0500 Received: by mail-il1-x133.google.com with SMTP id p15so16130573ilq.8; Mon, 01 Feb 2021 11:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GDenK5/Y6Tw0AuufIxmVZZ1MA9L3+vzEFpguQA9Cjls=; b=niKCoEfugQ5PK78TwJoKKMSo+2T21jM4fPm8pPUGvLZjL82EAWBjwnsKbjY+HYcyU6 aJjydNfJFTNsN3hsEOI7ubCpVGS74zVa/YExdywLmb9KDyeZIOCDZgomlvyC45q0zK0i S2mgH9PWFbGprjrAbzlO5XkiK8k/DK5GVLzsLjpjRYjC1sB/famY9ULIm/snHaGjKccR q6EbAIB+5LsPi7hcUqAoH+WmIvBJiWM2R7eNn+T6ft4Lq+qxEsaxMoaqPRBHvjfaVWhS yTBIeig1gn//crqBTFH1NcgANVI5Wyvbl1TeY44s0iFiE+Jbp5yDOZFdTVTj6B0FDJ6k gA4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GDenK5/Y6Tw0AuufIxmVZZ1MA9L3+vzEFpguQA9Cjls=; b=TLZVpfwp1Qn/llozCxUknDDhdW3edA+gLtUz3m8h/lC+wuq6SMzYi5yQu6E9hm/Ml3 L9A5zMF2GakLZHxdXEA/wSzhtNZ3C6ZnngHP3r/L1hyfVVOq7XsJttzy5bznUsBRslOc jWBV+us5/cJTS7UGWoQokWKwDW6lZ10wh/oU/qawW6WPcFbfjlzGM90pWy5C3StKbs0x 3QZrVe09K+EM7je7KtKc5EU/lgh4Uhfa/IFhBcYEqe8cJsRdhvEmRuJ7TUgdwn7i6bGr qUcx1O/i5fz72Zf0RsiKO9aIKKnz/VadgHO/a1BPjBRO6EoMy1rpzh4sFdWmAaStlNnx 261g== X-Gm-Message-State: AOAM532bU9PHmLPdQtkcv+GSJC1IMxBsHpZGqxUutNRWoeBTsg9Htt82 a/VVVj8bCIkR7EzLahVPF1lGVgCiVyLCX+0pskY= X-Google-Smtp-Source: ABdhPJwzc0t2XzSS0cYo/LZ3JL+MxIgQ8+UL10QgsFRolJRObMtAeWIIajsriOccHiDvNJLQNtaKuaXteSrX7PanraM= X-Received: by 2002:a92:cda1:: with SMTP id g1mr14217320ild.267.1612209594110; Mon, 01 Feb 2021 11:59:54 -0800 (PST) MIME-Version: 1.0 References: <20210131111316.232778-1-f4bug@amsat.org> <20210131111316.232778-10-f4bug@amsat.org> In-Reply-To: <20210131111316.232778-10-f4bug@amsat.org> From: Alistair Francis Date: Mon, 1 Feb 2021 11:59:25 -0800 Message-ID: Subject: Re: [PATCH 09/10] target: Move ARM_COMPATIBLE_SEMIHOSTING feature to target Kconfig To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=alistair23@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Chris Wulff , Sagar Karandikar , "Michael S. Tsirkin" , Anthony Green , Mark Cave-Ayland , "qemu-devel@nongnu.org Developers" , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Qemu-block , David Hildenbrand , Thomas Huth , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Artyom Tarasenko , Aleksandar Rikalo , Eduardo Habkost , Richard Henderson , Greg Kurz , qemu-s390x , qemu-arm , Michael Rolnik , "open list:New World" , Stafford Horne , =?UTF-8?B?QWxleCBCZW5uw6ll?= , David Gibson , Kevin Wolf , "open list:RISC-V" , Yoshinori Sato , Bastian Koppelmann , Cornelia Huck , Laurent Vivier , Max Reitz , Michael Walle , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Jan 31, 2021 at 3:14 AM Philippe Mathieu-Daud=C3=A9 wrote: > > ARM_COMPATIBLE_SEMIHOSTING is an architecture feature, move its > declaration to each target/ARCH/. > > Note, we do not modify the linux-user targets, as user-mode builds > don't use Kconfig. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Alistair > --- > default-configs/devices/arm-softmmu.mak | 1 - > default-configs/devices/riscv32-softmmu.mak | 1 - > default-configs/devices/riscv64-softmmu.mak | 1 - > target/arm/Kconfig | 1 + > target/riscv/Kconfig | 2 ++ > 5 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/de= vices/arm-softmmu.mak > index 341d439de6f..0824e9be795 100644 > --- a/default-configs/devices/arm-softmmu.mak > +++ b/default-configs/devices/arm-softmmu.mak > @@ -41,5 +41,4 @@ CONFIG_MICROBIT=3Dy > CONFIG_FSL_IMX25=3Dy > CONFIG_FSL_IMX7=3Dy > CONFIG_FSL_IMX6UL=3Dy > -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy > CONFIG_ALLWINNER_H3=3Dy > diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-config= s/devices/riscv32-softmmu.mak > index 5c9ad2590ef..94a236c9c25 100644 > --- a/default-configs/devices/riscv32-softmmu.mak > +++ b/default-configs/devices/riscv32-softmmu.mak > @@ -3,7 +3,6 @@ > # Uncomment the following lines to disable these optional devices: > # > #CONFIG_PCI_DEVICES=3Dn > -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy > > # Boards: > # > diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-config= s/devices/riscv64-softmmu.mak > index d5b2e25b6df..76b61956489 100644 > --- a/default-configs/devices/riscv64-softmmu.mak > +++ b/default-configs/devices/riscv64-softmmu.mak > @@ -3,7 +3,6 @@ > # Uncomment the following lines to disable these optional devices: > # > #CONFIG_PCI_DEVICES=3Dn > -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy > > # Boards: > # > diff --git a/target/arm/Kconfig b/target/arm/Kconfig > index 1f05de47ca6..ae89d05c7e5 100644 > --- a/target/arm/Kconfig > +++ b/target/arm/Kconfig > @@ -1,5 +1,6 @@ > config ARM > bool > + select ARM_COMPATIBLE_SEMIHOSTING > > config AARCH64 > bool > diff --git a/target/riscv/Kconfig b/target/riscv/Kconfig > index b9e5932f13f..c3b9d8a1cf1 100644 > --- a/target/riscv/Kconfig > +++ b/target/riscv/Kconfig > @@ -1,5 +1,7 @@ > config RISCV32 > bool > + select ARM_COMPATIBLE_SEMIHOSTING > > config RISCV64 > bool > + select ARM_COMPATIBLE_SEMIHOSTING > -- > 2.26.2 > >