From: Alistair Francis <alistair23@gmail.com>
To: "Milan P. Stanić" <mps@arvanta.net>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 1/1] util/util/cpuinfo-riscv.c: fix riscv64 build on musl libc
Date: Fri, 6 Sep 2024 11:28:39 +1000 [thread overview]
Message-ID: <CAKmqyKPwZPS0N29ANk0LEMoUHaNCH4z3cBE0OzjhCvuBA8AanQ@mail.gmail.com> (raw)
In-Reply-To: <20240905150702.2484-1-mps@arvanta.net>
On Fri, Sep 6, 2024 at 1:08 AM Milan P. Stanić <mps@arvanta.net> wrote:
>
> build fails on musl libc (alpine linux) with this error:
>
> ../util/cpuinfo-riscv.c: In function 'cpuinfo_init':
> ../util/cpuinfo-riscv.c:63:21: error: '__NR_riscv_hwprobe' undeclared (first use in this function); did you mean 'riscv_hwprobe'?
> 63 | if (syscall(__NR_riscv_hwprobe, &pair, 1, 0, NULL, 0) == 0
> | ^~~~~~~~~~~~~~~~~~
> | riscv_hwprobe
> ../util/cpuinfo-riscv.c:63:21: note: each undeclared identifier is reported only once for each function it appears in
> ninja: subcommand failed
>
> add '#include "asm/unistd.h"' to util/cpuinfo-riscv.c fixes build
>
> Signed-off-by: Milan P. Stanić <mps@arvanta.net>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> util/cpuinfo-riscv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util/cpuinfo-riscv.c b/util/cpuinfo-riscv.c
> index 497ce12680..8cacc67645 100644
> --- a/util/cpuinfo-riscv.c
> +++ b/util/cpuinfo-riscv.c
> @@ -9,6 +9,7 @@
> #ifdef CONFIG_ASM_HWPROBE_H
> #include <asm/hwprobe.h>
> #include <sys/syscall.h>
> +#include <asm/unistd.h>
> #endif
>
> unsigned cpuinfo;
> --
> 2.46.0
>
>
prev parent reply other threads:[~2024-09-06 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 15:06 [PATCH v2 1/1] util/util/cpuinfo-riscv.c: fix riscv64 build on musl libc Milan P. Stanić
2024-09-05 19:44 ` Richard Henderson
2024-09-05 19:57 ` Peter Maydell
2024-09-06 0:53 ` Alistair Francis
2024-09-06 1:28 ` Alistair Francis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPwZPS0N29ANk0LEMoUHaNCH4z3cBE0OzjhCvuBA8AanQ@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=mps@arvanta.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).