From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471AECA9EAC for ; Sat, 19 Oct 2019 15:53:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1251B21925 for ; Sat, 19 Oct 2019 15:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f6wYtBJb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1251B21925 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLr2e-0003vS-Ph for qemu-devel@archiver.kernel.org; Sat, 19 Oct 2019 11:53:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48985) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLr1X-0002eZ-Dc for qemu-devel@nongnu.org; Sat, 19 Oct 2019 11:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLr1V-0004F0-IQ for qemu-devel@nongnu.org; Sat, 19 Oct 2019 11:52:11 -0400 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:39094) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLr1U-0004EY-Gx for qemu-devel@nongnu.org; Sat, 19 Oct 2019 11:52:09 -0400 Received: by mail-ot1-x342.google.com with SMTP id s22so7523686otr.6 for ; Sat, 19 Oct 2019 08:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rMvTHWSOELfGobs11eDl0bpoEmKZrHWotVbs9e1qf+g=; b=f6wYtBJbcmuHjhI11SbCM/acPcShGDpBI6sdi6tn3DbJLu6JxZrtnx8xtEZLP+llZi 4sVW+4o4qgtc9GUX3QCLA0SL4O9NpptR9WL4BeQqGsXxJAvHPhNl8iSzaxKtEaKOMMq8 ZsxPWV5c4rsVZXX8436jxoeqIucFbr4nrKyFDqOzMEzpbUVvHCp0OpTXKBvEFeTFB1x2 a9YPUty+mp4o5HJS3pMbq2JzBsIzD3G0Z2yQpEakX+JAlmINYfxhZZKDpTT8mEAg3t2g 7vyCbRmbW7hqyIjfoD+Q06GQZzH2an81DGNn7wlpmHR+jIeUMJY1ZB0ENpZWY4T58z2f uvjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rMvTHWSOELfGobs11eDl0bpoEmKZrHWotVbs9e1qf+g=; b=ZnXkbpLUvUg4AYx0f8PsLmTxCJvi59j36BCd3UKgAILLuFqqw31PvFT5VepW6V0Ppn 1lO2VPPuD6D+b9P7HLJXWwhzGgIdtsIN637wNKpKRYIkfPqSxRzEoTtZ1LI2KsLO1we2 wioO+t3kaEkXMIolqrDJlwbSZArvKWvp9sD5HQSXMsh6nKjpXxrpQg/eho2Ov6HxI9Q/ elZxcLUXmg6IMhIfXcrOTOuM6lUF4Mtma1wuAl303dcZWuHB0tFc6Gqt2u/6NQafwOp7 4Kr53iysFyOxhuJQTWLlh0p0ifdbHQ/VfcCEmw+bhpfLvW3iXUqILPdTBOMIcEtRK6W3 UmEw== X-Gm-Message-State: APjAAAUp+TccGmfak5lXAkSrAOmfnK+Lh7MCM64nCUi9Pdl1Ka/dd/9I vBqcLhws1vXXTgfLYt7mhHylSKQLLmhVTwlB3En5rA== X-Google-Smtp-Source: APXvYqxiyP4lT3uFIQgpcWBFsekbGtMz8TQr4kNlJ7Hwnbb3sMAHEU1NmMRj/QBw8Bj9YPnQX+yaNpkBirL5AbygxRE= X-Received: by 2002:a05:6830:1d8f:: with SMTP id y15mr11346602oti.121.1571500327906; Sat, 19 Oct 2019 08:52:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:340a:0:0:0:0:0 with HTTP; Sat, 19 Oct 2019 08:52:07 -0700 (PDT) In-Reply-To: <20191019153437.9820-8-f4bug@amsat.org> References: <20191019153437.9820-1-f4bug@amsat.org> <20191019153437.9820-8-f4bug@amsat.org> From: Aleksandar Markovic Date: Sat, 19 Oct 2019 17:52:07 +0200 Message-ID: Subject: Re: [PATCH v2 07/11] tests/ssh_linux_malta: Run tests using a snapshot image To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000cf33230595456e94" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::342 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "qemu-devel@nongnu.org" , Aleksandar Markovic , Cleber Rosa , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000cf33230595456e94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Saturday, October 19, 2019, Philippe Mathieu-Daud=C3=A9 wrote: > If a test fails, it can corrupt the underlying QCow2 image, > making further tests failing. > Fix this by running each test with a snapshot. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > tests/acceptance/linux_ssh_mips_malta.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Aleksandar Markovic > diff --git a/tests/acceptance/linux_ssh_mips_malta.py > b/tests/acceptance/linux_ssh_mips_malta.py > index ffbb06f846..27907e8fbd 100644 > --- a/tests/acceptance/linux_ssh_mips_malta.py > +++ b/tests/acceptance/linux_ssh_mips_malta.py > @@ -90,7 +90,7 @@ class LinuxSSH(Test): > self.vm.add_args('-no-reboot', > '-kernel', kernel_path, > '-append', kernel_command_line, > - '-hda', image_path, > + '-drive', 'file=3D%s,snapshot=3Don' % image_pat= h, > '-netdev', 'user,id=3Dvnet,hostfwd=3D:127.0. > 0.1:0-:22', > '-device', 'pcnet,netdev=3Dvnet') > self.vm.launch() > -- > 2.21.0 > > > --000000000000cf33230595456e94 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Saturday, October 19, 2019, Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org> wrote:
If a test fails, it can corrupt the underlying QCow2 i= mage,
making further tests failing.
Fix this by running each test with a snapshot.

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
---
=C2=A0tests/acceptance/linux_ssh_mips_malta.py | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Aleksandar Markovi= c <amarkovic@wavecomp.com>=
=C2=A0
diff --git a/tests/acceptance/linux_ssh_mips_malta.py b/tests/acceptan= ce/linux_ssh_mips_malta.py
index ffbb06f846..27907e8fbd 100644
--- a/tests/acceptance/linux_ssh_mips_malta.py
+++ b/tests/acceptance/linux_ssh_mips_malta.py
@@ -90,7 +90,7 @@ class LinuxSSH(Test):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.vm.add_args('-no-reboot', =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '-kernel', kernel_path,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '-append', kernel_command_line,
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0'-hda', image_path,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0'-drive', 'file=3D%s,snapshot=3Don' % imag= e_path,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '-netdev', 'user,id=3Dvnet,hostfwd=3D:127.0.<= wbr>0.1:0-:22',
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 '-device', 'pcnet,netdev=3Dvnet')
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0self.vm.launch()
--
2.21.0


--000000000000cf33230595456e94--