From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D30DC43603 for ; Sat, 14 Dec 2019 21:49:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06586207FD for ; Sat, 14 Dec 2019 21:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OTuq/b2a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06586207FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igFI8-0003WY-23 for qemu-devel@archiver.kernel.org; Sat, 14 Dec 2019 16:49:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44638) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igFH2-0002bN-2s for qemu-devel@nongnu.org; Sat, 14 Dec 2019 16:48:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igFH0-0000M0-Kj for qemu-devel@nongnu.org; Sat, 14 Dec 2019 16:48:27 -0500 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]:42475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igFGz-0000JG-IV; Sat, 14 Dec 2019 16:48:26 -0500 Received: by mail-ot1-x333.google.com with SMTP id 66so3765943otd.9; Sat, 14 Dec 2019 13:48:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=22Xie9AzVxk20tNtnNAjSLZmLhAA28fbehMxyVbIO+w=; b=OTuq/b2aotnqEf7kTknuq9fvbsX+vNtk/kKWduu0frt0daRER6QdMjxeeCM7OfWmeS 6l5C14n/4elKQPNYDaAppS2Xr+Uxf8mDBvs+K9kvDAGgeDtrvsk8zjbQQzTMvJk1lQGB HKZVuuILvpE7jlO/ewMb3gFVl1lguWYIjqO0/rHh6H54mv5C1kZgeD7UUdDqLLcGTAbi YHGZY6FzU0NeK/VB6saG3Psvw9agn8KCSeBjS7qpUHVp56Dc6h61rwa3SQPhAcM+ZNiN KAK5UWJBp/GXFgv/c2G2b16FeSF+VAskKHMMkqOb2/+C4U7u8g2O5QBQoDnUHB1H9s4a 3Ptg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=22Xie9AzVxk20tNtnNAjSLZmLhAA28fbehMxyVbIO+w=; b=LZ2ylxBksg4HGweoYPrVhpW715x/cJydLmVxPpnJGOuxTADoOYmXzSKdOC1HCYCkXh MnOkniqOLAT2W874jKk09oA0pY0ABlrv6IhaIMv4u30sDD/xlzDyEXcRGDrHdq1x/bIO Ol6VphCZB6CSM/IYX/FATWem9lRLvW9NuYY2vuU2N4pn6PO8nh/rHhzV3Ez6BzSh8VA5 UZr8kE5orueGoRVwRl5GLcM88gjWRsUF53AfLJ8L1QOPtk1Ebh9tBBliSXl3LXf1BmRn uMY2UhnpKZ76lf8qbNtdmx5fn2+SrMg6RwBFOA9xLiAJQxoJn0/f5YZ2BVSS7NGCp+Rr Cm1Q== X-Gm-Message-State: APjAAAU/cURf3GUMKWKLhCGmJ6u+Rfvr76/Y8Gq0QNASBKM2WdGkxQLQ jLWPqKKxnMJTo9iIdGwfeTuz+Hq0Yp2d6FyO/w5VoA== X-Google-Smtp-Source: APXvYqwoU94NKUlkZlLqeUQcVXfb/fM1vgLkCA9AIv6rJJ2kAyMmrQqJE4Sr8eKEXUONgjakr+h8TIQxm1zu3sj9AFI= X-Received: by 2002:a05:6830:1042:: with SMTP id b2mr21379234otp.306.1576343854808; Sat, 14 Dec 2019 09:17:34 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a9d:d21:0:0:0:0:0 with HTTP; Sat, 14 Dec 2019 09:17:34 -0800 (PST) In-Reply-To: References: From: Aleksandar Markovic Date: Sat, 14 Dec 2019 18:17:34 +0100 Message-ID: Subject: Re: [PATCH 00/10] Fixes for DP8393X SONIC device emulation To: Finn Thain Content-Type: multipart/alternative; boundary="00000000000082848b0599ad27cd" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::333 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , "qemu-devel@nongnu.org" , "qemu-stable@nongnu.org" , Herve Poussineau , Aleksandar Rikalo , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000082848b0599ad27cd Content-Type: text/plain; charset="UTF-8" On Saturday, December 14, 2019, Finn Thain wrote: > Hi All, > > There is a bug in the DP8393X emulation that can stop packet reception. > > Can you provide the details of your test scenario? Thanks, Aleksandar > Whilst debugging that issue I found that the receiver algorithm differs > from the one described in the National Semiconductor datasheet. > > These issues and others are addressed by this patch series. > > This series has only been tested with Linux/m68k guests. It needs further > testing with MIPS Jazz guests such as NetBSD or Windows NT. > > Thanks. > > > Finn Thain (10): > dp8393x: Mask EOL bit from descriptor addresses > dp8393x: Clean up endianness hacks > dp8393x: Have dp8393x_receive() return the packet size > dp8393x: Don't advance RX descriptor twice > dp8393x: Update LLFA register > dp8393x: Clear RRRA command register bit only when appropriate > dp8393x: Implement TBWC0 and TBWC1 registers to restore buffer state > dp8393x: Implement packet size limit and RBAE interrupt > dp8393x: Don't stop reception upon RBE interrupt assertion > dp8393x: Don't clobber packet checksum > > hw/net/dp8393x.c | 80 +++++++++++++++++++++++++++++++----------------- > 1 file changed, 52 insertions(+), 28 deletions(-) > > -- > 2.23.0 > > > --00000000000082848b0599ad27cd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Saturday, December 14, 2019, Finn Thain <fthain@telegraphics.com.au> wrote:
Hi All,

There is a bug in the DP8393X emulation that can stop packet reception.


Can you provide the details of your te= st scenario?

Thanks,
Aleksandar


=C2=A0
Whilst debugging that issue I found that the receiver algorithm differs
from the one described in the National Semiconductor datasheet.

These issues and others are addressed by this patch series.

This series has only been tested with Linux/m68k guests. It needs further testing with MIPS Jazz guests such as NetBSD or Windows NT.

Thanks.


Finn Thain (10):
=C2=A0 dp8393x: Mask EOL bit from descriptor addresses
=C2=A0 dp8393x: Clean up endianness hacks
=C2=A0 dp8393x: Have dp8393x_receive() return the packet size
=C2=A0 dp8393x: Don't advance RX descriptor twice
=C2=A0 dp8393x: Update LLFA register
=C2=A0 dp8393x: Clear RRRA command register bit only when appropriate
=C2=A0 dp8393x: Implement TBWC0 and TBWC1 registers to restore buffer state=
=C2=A0 dp8393x: Implement packet size limit and RBAE interrupt
=C2=A0 dp8393x: Don't stop reception upon RBE interrupt assertion
=C2=A0 dp8393x: Don't clobber packet checksum

=C2=A0hw/net/dp8393x.c | 80 +++++++++++++++++++++++++++++++-----------= ------
=C2=A01 file changed, 52 insertions(+), 28 deletions(-)

--
2.23.0


--00000000000082848b0599ad27cd--