qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	Sarah Harris <S.E.Harris@kent.ac.uk>,
	Pavel Dovgalyuk <dovgaluk@ispras.ru>,
	Richard Henderson <richard.henderson@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Michael Rolnik <mrolnik@gmail.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH v36 11/17] target/avr: Add limited support for USART and 16 bit timer peripherals
Date: Wed, 27 Nov 2019 19:43:50 +0100	[thread overview]
Message-ID: <CAL1e-=i6tctJ6bKo7mz2fmSzPXpdMY1kV1WrKhL5TCAKd0DkcQ@mail.gmail.com> (raw)
In-Reply-To: <81b62c00-243e-b76e-f52c-4f681b47b727@redhat.com>

> > +/* Offsets of registers. */
> > +#define USART_DR   0x06
> > +#define USART_CSRA  0x00
> > +#define USART_CSRB  0x01
> > +#define USART_CSRC  0x02
> > +#define USART_BRRH 0x05
> > +#define USART_BRRL 0x04
> > +
> > +/* Relevant bits in regiters. */
> > +#define USART_CSRA_RXC    (1 << 7)
> > +#define USART_CSRA_TXC    (1 << 6)
> > +#define USART_CSRA_DRE    (1 << 5)
> > +#define USART_CSRA_MPCM   (1 << 0)
> > +
> > +#define USART_CSRB_RXCIE  (1 << 7)
> > +#define USART_CSRB_TXCIE  (1 << 6)
> > +#define USART_CSRB_DREIE  (1 << 5)
> > +#define USART_CSRB_RXEN   (1 << 4)
> > +#define USART_CSRB_TXEN   (1 << 3)
> > +#define USART_CSRB_CSZ2   (1 << 2)
> > +#define USART_CSRB_RXB8   (1 << 1)
> > +#define USART_CSRB_TXB8   (1 << 0)
> > +
> > +#define USART_CSRC_MSEL1  (1 << 7)
> > +#define USART_CSRC_MSEL0  (1 << 6)
> > +#define USART_CSRC_PM1    (1 << 5)
> > +#define USART_CSRC_PM0    (1 << 4)
> > +#define USART_CSRC_CSZ1   (1 << 2)
> > +#define USART_CSRC_CSZ0   (1 << 1)
>
> The previous definitions can go into hw/char/avr_usart.c.
>

Why?


  reply	other threads:[~2019-11-27 18:49 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24  5:02 [PATCH v36 00/17] QEMU AVR 8 bit cores Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 01/17] target/avr: Add outward facing interfaces and core CPU logic Michael Rolnik
2019-11-24 15:17   ` Aleksandar Markovic
2019-11-25 18:51     ` Thomas Huth
2019-11-25 19:06       ` Aleksandar Markovic
2019-11-24 16:21   ` Aleksandar Markovic
2019-11-24 20:08     ` Aleksandar Markovic
2019-11-26 22:54     ` Philippe Mathieu-Daudé
2019-11-25  1:29   ` Aleksandar Markovic
2019-11-26  1:25   ` Aleksandar Markovic
2019-11-24  5:02 ` [PATCH v36 02/17] target/avr: Add instruction helpers Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 03/17] target/avr: Add instruction decoding Michael Rolnik
2019-11-24 15:22   ` Aleksandar Markovic
2019-11-24  5:02 ` [PATCH v36 04/17] target/avr: Add instruction translation - Registers definition Michael Rolnik
2019-11-26 19:48   ` Aleksandar Markovic
2019-11-26 20:40     ` Michael Rolnik
2019-11-26 23:06   ` Philippe Mathieu-Daudé
2019-11-24  5:02 ` [PATCH v36 05/17] target/avr: Add instruction translation - Arithmetic and Logic Instructions Michael Rolnik
2019-11-26 23:04   ` Philippe Mathieu-Daudé
2019-11-24  5:02 ` [PATCH v36 06/17] target/avr: Add instruction translation - Branch Instructions Michael Rolnik
2019-11-26 23:04   ` Philippe Mathieu-Daudé
2019-11-24  5:02 ` [PATCH v36 07/17] target/avr: Add instruction translation - Bit and Bit-test Instructions Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 08/17] target/avr: Add instruction translation - MCU Control Instructions Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 09/17] target/avr: Add instruction translation - CPU main translation function Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 10/17] target/avr: Add instruction disassembly function Michael Rolnik
2019-11-24 15:02   ` Aleksandar Markovic
2019-11-24 15:05   ` Aleksandar Markovic
2019-11-26  1:11   ` Aleksandar Markovic
2019-11-26 19:52   ` Aleksandar Markovic
2019-11-26 20:32     ` Michael Rolnik
2019-11-26 22:24       ` Aleksandar Markovic
2019-11-26 23:14   ` Aleksandar Markovic
2019-11-26 23:59   ` Philippe Mathieu-Daudé
2019-11-27  6:21     ` Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 11/17] target/avr: Add limited support for USART and 16 bit timer peripherals Michael Rolnik
2019-11-24 14:58   ` Aleksandar Markovic
2019-11-27 17:07   ` Philippe Mathieu-Daudé
2019-11-27 18:43     ` Aleksandar Markovic [this message]
2019-11-27 18:46       ` Michael Rolnik
2019-11-27 19:29         ` Aleksandar Markovic
2019-11-27 20:02       ` Aleksandar Markovic
2019-11-24  5:02 ` [PATCH v36 12/17] target/avr: Add example board configuration Michael Rolnik
2019-11-26  1:08   ` Aleksandar Markovic
2019-11-26 23:03     ` Philippe Mathieu-Daudé
2019-11-24  5:02 ` [PATCH v36 13/17] target/avr: Register AVR support with the rest of QEMU Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 14/17] target/avr: Update build system Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 15/17] target/avr: Add boot serial test Michael Rolnik
2019-11-24  5:02 ` [PATCH v36 16/17] target/avr: Add Avocado test Michael Rolnik
2019-11-24 15:18   ` Aleksandar Markovic
2019-11-26 23:14   ` Philippe Mathieu-Daudé
2019-11-24  5:02 ` [PATCH v36 17/17] target/avr: Update MAINTAINERS file Michael Rolnik
2019-11-25 23:49   ` Aleksandar Markovic
2019-11-26  2:06     ` Cleber Rosa
2019-11-27 23:53     ` Eduardo Habkost
2019-11-26  3:17   ` Aleksandar Markovic
2019-11-26 19:05     ` Michael Rolnik
2019-11-26 19:39       ` Aleksandar Markovic
2019-11-26 20:41         ` Michael Rolnik
2019-11-28  9:34           ` Sarah Harris
2019-11-25  8:47 ` [PATCH v36 00/17] QEMU AVR 8 bit cores Philippe Mathieu-Daudé
2019-11-25 23:58 ` Aleksandar Markovic
2019-11-26  1:22 ` Aleksandar Markovic
2019-11-26 23:21 ` Aleksandar Markovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL1e-=i6tctJ6bKo7mz2fmSzPXpdMY1kV1WrKhL5TCAKd0DkcQ@mail.gmail.com' \
    --to=aleksandar.m.mail@gmail.com \
    --cc=S.E.Harris@kent.ac.uk \
    --cc=dovgaluk@ispras.ru \
    --cc=imammedo@redhat.com \
    --cc=mrolnik@gmail.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).