[Qemu-devel] Malta-related files in MAINTAINERS

[Qemu-devel] Malta-related files in MAINTAINERS

[Aleksandar Markovic]

Hello, Philippe.

Currently, we have these two files in Malta MAINTAINERS section:
F: hw/mips/mips_malta.c
F: tests/acceptance/linux_ssh_mips_malta.py

Do we need to add more files, or other Malta-related files naturally belong to some other sections, or are shared by many boards?

Yours, Aleksandae

Re: [Qemu-devel] Malta-related files in MAINTAINERS

[Philippe Mathieu-Daudé]

Hi Aleksandar,

On 5/29/19 10:22 AM, Aleksandar Markovic wrote:
> Hello, Philippe.
> 
> Currently, we have these two files in Malta MAINTAINERS section:
> F: hw/mips/mips_malta.c
> F: tests/acceptance/linux_ssh_mips_malta.py
> 
> Do we need to add more files, or other Malta-related files naturally belong to some other sections, or are shared by many boards?

Not related to your question:

The Malta model is an old one in QEMU, as such it uses the condensed
format where all the Malta specific devices are self-contained in the
same file. This organization has Pro/Cons.

New MIPS boards where added and instead of reuse components, they were
duplicated few times, so now it is harder to maintain.

Back to your question:

All the South Bridge and 'below' devices are shared with the x86 PC
machine, except:

- FDC37M81X Super I/O: maintained by 'PC Chipset'
- PIIX4 South Bridge: maintained by 'PC' but this might change
  as Michael S. Tsirkin is mostly interested in the PIIX3.
  I have a WIP painful series related to PIIX cleanup.

The North Bridge differs and is Malta specific, so you can add it in
this section:

- hw/mips/gt64xxx_pci.c

I'll sort the PIIX some day ;)

Regards,

Phil.

Re: [Qemu-devel] Malta-related files in MAINTAINERS

[Aleksandar Markovic]

On May 29, 2019 3:45 PM, "Philippe Mathieu-Daudé" <philmd@redhat.com> wrote:
>
> Hi Aleksandar,
>
> On 5/29/19 10:22 AM, Aleksandar Markovic wrote:
> > Hello, Philippe.
> >
> > Currently, we have these two files in Malta MAINTAINERS section:
> > F: hw/mips/mips_malta.c
> > F: tests/acceptance/linux_ssh_mips_malta.py
> >
> > Do we need to add more files, or other Malta-related files naturally
belong to some other sections, or are shared by many boards?
>
> Not related to your question:
>
> The Malta model is an old one in QEMU, as such it uses the condensed
> format where all the Malta specific devices are self-contained in the
> same file. This organization has Pro/Cons.
>
> New MIPS boards where added and instead of reuse components, they were
> duplicated few times, so now it is harder to maintain.
>
> Back to your question:
>
> All the South Bridge and 'below' devices are shared with the x86 PC
> machine, except:
>
> - FDC37M81X Super I/O: maintained by 'PC Chipset'
> - PIIX4 South Bridge: maintained by 'PC' but this might change
>   as Michael S. Tsirkin is mostly interested in the PIIX3.
>   I have a WIP painful series related to PIIX cleanup.
>
> The North Bridge differs and is Malta specific, so you can add it in
> this section:
>
> - hw/mips/gt64xxx_pci.c
>
> I'll sort the PIIX some day ;)
>

I honestly appreciate your detailed response.

Aleksandar

> Regards,
>
> Phil.
>